Bug 220439 - mail/msmtp: Add dependency on bash
Summary: mail/msmtp: Add dependency on bash
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Roman Bogorodskiy
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2017-07-02 23:21 UTC by Moritz Wilhelmy
Modified: 2017-07-15 06:18 UTC (History)
0 users

See Also:
novel: maintainer-feedback+
novel: merge-quarterly+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Moritz Wilhelmy 2017-07-02 23:21:49 UTC 
The msmtpq utility depends on bash, so I think the port should either depend on bash or msmtpq should be a port option?
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-07-09 04:48:23 UTC 
A commit references this bug:

Author: novel
Date: Sun Jul  9 04:47:17 UTC 2017
New revision: 445367
URL: https://svnweb.freebsd.org/changeset/ports/445367

Log:
  mail/msmtp: depend on bash for msmtpq

  When MSMTPQ option (which installs offline message queueing scripts)
  is enabled, depend on shells/bash because these scripts require bash.

  Bump PORTREVISION.

  PR:		220439
  Submitted by:	Moritz Wilhelmy
  MFH:		2017Q3

Changes:
  head/mail/msmtp/Makefile
Comment 2 Roman Bogorodskiy freebsd_committer freebsd_triage 2017-07-09 05:02:02 UTC 
Thanks for noticing that.

> ... the port should either depend on bash or msmtpq should be a port option?

Such an option already exists:

$ make showconfig|grep -i msmtpq
     MSMTPQ=on: Install offline messaging scripts
$

I've added bash dependency when MSMTPQ is enabled.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-07-15 06:16:59 UTC 
A commit references this bug:

Author: novel
Date: Sat Jul 15 06:16:09 UTC 2017
New revision: 445848
URL: https://svnweb.freebsd.org/changeset/ports/445848

Log:
  MFH: r445367

  mail/msmtp: depend on bash for msmtpq

  When MSMTPQ option (which installs offline message queueing scripts)
  is enabled, depend on shells/bash because these scripts require bash.

  Bump PORTREVISION.

  PR:		220439
  Submitted by:	Moritz Wilhelmy
  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/mail/msmtp/Makefile
Comment 4 Roman Bogorodskiy freebsd_committer freebsd_triage 2017-07-15 06:18:55 UTC 
Should be fixed now, thanks!