Bug 220814 - net-im/qTox: Update to 1.11.0
Summary: net-im/qTox: Update to 1.11.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-18 02:45 UTC by Yuri Victorovich
Modified: 2017-07-19 05:32 UTC (History)
1 user (show)

See Also:

Attachments
patch (7.81 KB, patch)
2017-07-18 02:45 UTC, Yuri Victorovich 		yuri: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-07-18 02:45:09 UTC 
Created attachment 184459 [details]
patch

Changes:
* Switched to cmake/ninja
* net-im/qTox/files/patch-qtox.pro is deleted
* Added audio/opus dependency
* Still requires qmake_build, see bug#220813

QAs:
* Builds in poudriere
* okayed by portlint
* runs fine
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-07-18 16:42:43 UTC 
A commit references this bug:

Author: tcberner
Date: Tue Jul 18 16:41:57 UTC 2017
New revision: 446146
URL: https://svnweb.freebsd.org/changeset/ports/446146

Log:
  net-im/qTox: Update to 1.11.0

  PR:		220814
  Submitted by:	Yuri Victorovich <yuri@rawbw.com> (maintainer)

Changes:
  head/net-im/qTox/Makefile
  head/net-im/qTox/distinfo
  head/net-im/qTox/files/patch-CMakeLists.txt
  head/net-im/qTox/files/patch-qtox.pro
  head/net-im/qTox/files/patch-src_main.cpp
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2017-07-18 16:45:46 UTC 
Committed. Thanks.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2017-07-19 05:18:03 UTC 
Comment on attachment 184459 [details]
patch

> -USES=		compiler:c++11-lib desktop-file-utils gettext gmake openal:soft pkgconfig qmake
> +USES=		compiler:c++11-lib desktop-file-utils gettext openal:soft pkgconfig cmake

Can you sort USES alphabetically?

> -USE_QT5=	core gui network xml opengl sql sql-sqlite3_run widgets svg \
> +USE_QT5=	core gui network xml opengl sql sql-sqlite3_run widgets svg testlib \

PLIST_FILES doesn't list test binaries. Can append _build to drop runtime dependency on Qt5Test?

> -	@${GZIP_CMD} < ${WRKSRC}/img/icons/qtox.svg > ${STAGEDIR}${PREFIX}/share/icons/hicolor/scalable/apps/qtox.svgz
> +	@${GZIP_CMD} \
> +		< ${STAGEDIR}${PREFIX}/share/icons/hicolor/scalable/apps/qtox.svg \
> +		> ${STAGEDIR}${PREFIX}/share/icons/hicolor/scalable/apps/qtox.svgz
> +	@${RM} ${STAGEDIR}${PREFIX}/share/icons/hicolor/scalable/apps/qtox.svg

Why not save 2 lines by using -Sz, see gzip(1) manpage ?
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2017-07-19 05:32:22 UTC 
(In reply to Jan Beich from comment #3)

> Can you sort USES alphabetically?

It's not always beneficial. For example, in USE_QT5 'core' should logically come earlier. Also, see bug#193792

> PLIST_FILES doesn't list test binaries. Can append _build to drop runtime dependency on Qt5Test?

> Why not save 2 lines by using -Sz, see gzip(1) manpage ?

Will do with the next update.

Thanks for your suggestions!