Bug 220886 - [PATCH] devel/arcanist: add php-hash to depends
Summary: [PATCH] devel/arcanist: add php-hash to depends
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-07-20 17:26 UTC by Li-Wen Hsu
Modified: 2017-07-24 11:11 UTC (History)
1 user (show)

See Also:
grembo: maintainer-feedback+
lwhsu: merge-quarterly+

Attachments
arcanist.diff (489 bytes, patch)
2017-07-20 17:26 UTC, Li-Wen Hsu 		grembo: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Li-Wen Hsu freebsd_committer freebsd_triage 2017-07-20 17:26:28 UTC 
Created attachment 184552 [details]
arcanist.diff

Got this while submitting a differential:

```
PHP Fatal error:  Call to undefined function hash() in /usr/local/lib/php/arcanist/src/upload/ArcanistFileDataRef.php on line 359
```

Attached patch adds php-hash to depends.
Comment 1 Michael Gmelin freebsd_committer freebsd_triage 2017-07-20 22:14:59 UTC 
Approved, do you have time to commit and MFH to 2017Q3?
Comment 2 Li-Wen Hsu freebsd_committer freebsd_triage 2017-07-20 22:18:02 UTC 
No problem, I'll do it.
Comment 3 Michael Gmelin freebsd_committer freebsd_triage 2017-07-20 22:22:19 UTC 
(In reply to Li-Wen Hsu from comment #2)
Much appreciated, thank you!
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-07-20 22:44:32 UTC 
A commit references this bug:

Author: lwhsu
Date: Thu Jul 20 22:44:02 UTC 2017
New revision: 446298
URL: https://svnweb.freebsd.org/changeset/ports/446298

Log:
  Add required php-hash to the dependencies

  PR:		220886
  Submitted by:	lwhsu
  Approved by:	grembo
  MFH:		2017Q3

Changes:
  head/devel/arcanist/Makefile
Comment 5 Li-Wen Hsu freebsd_committer freebsd_triage 2017-07-24 00:51:03 UTC 
MFH approved by miwi.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-07-24 11:10:13 UTC 
A commit references this bug:

Author: lwhsu
Date: Mon Jul 24 11:09:28 UTC 2017
New revision: 446520
URL: https://svnweb.freebsd.org/changeset/ports/446520

Log:
  MFH: r446298

  Add required php-hash to the dependencies

  PR:		220886
  Submitted by:	lwhsu
  Approved by:	grembo

  Approved by:	ports-secteam (miwi)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/devel/arcanist/Makefile