Bug 220974 - graphics/graphene: Fails to build when GTKDOC option enabled (No such file or directory: 'gtkdoc-scan')
Summary: graphics/graphene: Fails to build when GTKDOC option enabled (No such file or...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-24 18:33 UTC by Grzegorz Junka
Modified: 2018-02-14 21:16 UTC (History)
4 users (show)

See Also:
pi: maintainer-feedback-


Attachments
Graphene fails when docs are enabled - full logs (80.71 KB, text/x-log)
2017-07-24 18:33 UTC, Grzegorz Junka
no flags Details
Poudriere log for failed graphics/graphene install (78.85 KB, text/plain)
2017-11-22 03:58 UTC, poorandunlucky
no flags Details
svn-diff-graphene-Makefile (501 bytes, patch)
2018-02-13 00:20 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Junka 2017-07-24 18:33:06 UTC
Created attachment 184672 [details]
Graphene fails when docs are enabled - full logs

Build fails when OPTIONS_FILE_SET+=GTKDOC

FileNotFoundError: [Errno 2] No such file or directory: 'gtkdoc-scan'
Installing src/libgraphene-1.0.so.0.600.0 to /wrkdirs/usr/ports/graphics/graphene/work/stage/usr/local/lib/libgraphene-1.0.so.0.600.0

Full log attached
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2017-07-24 21:27:35 UTC
Make Summary more verbose.
Comment 2 poorandunlucky 2017-11-22 03:58:39 UTC
Created attachment 188188 [details]
Poudriere log for failed graphics/graphene install

The build fails while running the script meson-install.
Comment 3 poorandunlucky 2017-11-22 03:59:30 UTC
Also fails for me, using Poudriere; builds fails when it fails to run script meson-install.

Disabling GTKDOC in options allows build to continue.
Comment 4 Walter Schwarzenfeld 2018-02-12 18:08:10 UTC
Tested it on 10.4 and 11.1 with poudriere. Compiles fine with GTKDOC=on . Can you confirm?
Comment 5 John Hein 2018-02-12 23:53:20 UTC
Fails for me in poudriere updated with today's ports tree with GTKDOC on - (this is on a recent 10-stable, but I don't think it matters).  It looks like this port (graphene) is missing a dependency (BUILD) on gtk-doc...

===>   Generating temporary packing list
[0/1] /usr/local/bin/python3.6 /usr/local/bin/meson --internal install /wrkdirs/usr/ports/graphics/graphene/work/graph
ene-1.6.0/_build/meson-private/install.dat
Building documentation for graphene
Traceback (most recent call last):
  File "/usr/local/bin/meson", line 37, in <module>
    sys.exit(main())
  File "/usr/local/bin/meson", line 34, in main
    return mesonmain.run(sys.argv[1:], launcher)
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/mesonmain.py", line 311, in run
    sys.exit(run_script_command(args[1:]))
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/mesonmain.py", line 278, in run_script_command
    return cmdfunc(cmdargs)
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/scripts/gtkdochelper.py", line 218, in run
    options.mode)
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/scripts/gtkdochelper.py", line 109, in build_gtkdoc
    gtkdoc_run_check(scan_cmd, abs_out)
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/scripts/gtkdochelper.py", line 51, in gtkdoc_run_check
    p, out = Popen_safe(cmd, cwd=cwd, stderr=subprocess.STDOUT)[0:2]
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/mesonlib.py", line 548, in Popen_safe
    stderr=stderr, **kwargs)
  File "/usr/local/lib/python3.6/subprocess.py", line 709, in __init__
    restore_signals, start_new_session)
  File "/usr/local/lib/python3.6/subprocess.py", line 1344, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'gtkdoc-scan': 'gtkdoc-scan'



This change should fix it:

--- Makefile    (revision 461580)
+++ Makefile    (working copy)
@@ -25,6 +25,7 @@
 #INTROSPECTION_USE=    gnome=introspection:build
 #INTROSPECTION_MESON_OFF=      -Denable-introspection=false
 
+GTKDOC_BUILD_DEPENDS=  gtk-doc>0:textproc/gtk-doc
 GTKDOC_MESON_TRUE=     enable-gtk-doc
 GTKDOC_DESC=           Build documentation
 

Without the above patch, a poudriere 'testport' build fails to 'stage' (with the above error).

With the above patch, it builds, stages, installs successfully.
Comment 6 Walter Schwarzenfeld 2018-02-13 00:20:34 UTC
Created attachment 190560 [details]
svn-diff-graphene-Makefile

You are right. Seems I have problems with poudriere options -c.
Fix seems to work.
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2018-02-14 21:16:00 UTC
Committed, thanks!
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-02-14 21:16:27 UTC
A commit references this bug:

Author: pi
Date: Wed Feb 14 21:15:32 UTC 2018
New revision: 461838
URL: https://svnweb.freebsd.org/changeset/ports/461838

Log:
  graphics/graphene: fix build when GTKDOC option enabled, pet portlint

  ... by adding BUILD_DEPENDS textproc/gtk-doc for the GTKDOC case

  PR:		220974
  Submitted by:	Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>
  Reported by:	Grzegorz Junka <list1@gjunka.com>

Changes:
  head/graphics/graphene/Makefile
  head/graphics/graphene/pkg-descr