Bug 221073 - net-im/gloox: Update to 1.0.20
Summary: net-im/gloox: Update to 1.0.20
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2017-07-28 20:30 UTC by Demetris Procopiou
Modified: 2017-08-18 04:19 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback+

Attachments
patch (3.90 KB, patch)
2017-07-28 20:30 UTC, Demetris Procopiou 		dbaio: maintainer-approval+
Details | Diff
patch-fixed (14.20 KB, patch)
2017-08-04 17:31 UTC, Demetris Procopiou 		dem.procopiou: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Demetris Procopiou 2017-07-28 20:30:03 UTC 
Created attachment 184811 [details]
patch

- update to 1.0.20
- added some code patches
- update pkg-plist
Comment 1 Danilo G. Baio freebsd_committer freebsd_triage 2017-07-28 21:44:16 UTC 
Comment on attachment 184811 [details]
patch

You can set maintainer-approval to + on attachments for ports you are MAINTAINER of.
Comment 2 Demetris Procopiou 2017-07-28 22:12:42 UTC 
(In reply to Danilo G. Baio from comment #1)
Ok, thanks for letting me know.
Comment 3 Danilo G. Baio freebsd_committer freebsd_triage 2017-07-30 13:07:17 UTC 
Hi Demetris.
I couldn't build it.
Build logs are here: http://poudriere.bs2.com.br/poudriere/data/latest-per-pkg/gloox/1.0.20/
Could you take a look?
Comment 4 Demetris Procopiou 2017-08-04 17:31:03 UTC 
Created attachment 185024 [details]
patch-fixed

updated patch
Comment 5 Richard Gallamore freebsd_committer freebsd_triage 2017-08-11 17:52:07 UTC 
* Many patchfiles are only modifying date/time, please remove these patches.

* There are many patchfiles that are similar modifying the same thing. Instead of creating a patch for each, a REINPLACE_CMD should do the trick.


${REINPLACE_CMD} 's/<stdio.h>/<ctime>/ ; s/<locale.h>/<clocale>/' \
 <tab>            ${WRKSRC}/foo.h ${WRKSRC}/bar.h ...  ...  ...

Also add a comment on why these are being changed.
Comment 6 Steve Wills freebsd_committer freebsd_triage 2017-08-18 03:28:17 UTC 
(In reply to Richard Gallamore from comment #5)
I tend to prefer patches to REINPLACE_CMD where possible. Calling REINPLACE_CMD can break silently. Also, it makes it a lot harder to get changes upstream.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-08-18 03:34:29 UTC 
A commit references this bug:

Author: swills
Date: Fri Aug 18 03:33:25 UTC 2017
New revision: 448205
URL: https://svnweb.freebsd.org/changeset/ports/448205

Log:
  net-im/gloox: Update to 1.0.20

  PR:		221073
  Submitted by:	Demetris Procopiou <dem.procopiou@gmail.com> (maintainer)

Changes:
  head/net-im/gloox/Makefile
  head/net-im/gloox/distinfo
  head/net-im/gloox/files/patch-src_examples_adhoc__example.cpp
  head/net-im/gloox/files/patch-src_examples_annotations__example.cpp
  head/net-im/gloox/files/patch-src_examples_bookmarkstorage__example.cpp
  head/net-im/gloox/files/patch-src_examples_component__example.cpp
  head/net-im/gloox/files/patch-src_examples_disco__example.cpp
  head/net-im/gloox/files/patch-src_examples_privacylist__example.cpp
  head/net-im/gloox/files/patch-src_examples_privatexml__example.cpp
  head/net-im/gloox/files/patch-src_examples_register__example.cpp
  head/net-im/gloox/files/patch-src_examples_reset__example.cpp
  head/net-im/gloox/files/patch-src_examples_roster__example.cpp
  head/net-im/gloox/files/patch-src_examples_vcard__example.cpp
  head/net-im/gloox/pkg-plist
Comment 8 Steve Wills freebsd_committer freebsd_triage 2017-08-18 03:34:59 UTC 
Committed, thanks!
Comment 9 Richard Gallamore freebsd_committer freebsd_triage 2017-08-18 04:19:28 UTC 
(In reply to Steve Wills from comment #6)
Will be more considerate with patches in the future.