Created attachment 185027 [details] patch * License should be GPLv3 * Added LIB_DEPENDS=libfftw3f.so:math/fftw3-float * Removed USE_XORG=xt QAs: * poudriere * portlint * runs fine
QA looks good, pending maintainer approval.
Created attachment 185302 [details] patch Few more changes: * set LIBSCSYNTH=ON to build the dynamic library * added the port option HELP allowing to disable/enable help * added the port option SUPERNOVA enabling supernova as optional audio synthesis server * added patched fixing the code for supernova * added the patch fixing -lX11 for one of the plugins that was missing * aligned sections Still passes poudriere build with all option combinations.
The new patch fails to build on 10.3. /usr/include/c++/v1/atomic:887:58: error: no viable conversion from 'boost::lockfree::detail::tagged_ptr<nova::freelist::freelist_node>' to '_Atomic(boost::lockfree::detail::tagged_ptr<nova::freelist::freelist_node>)' _LIBCPP_CONSTEXPR __atomic_base(_Tp __d) _NOEXCEPT : __a_(__d) {} ^ ~~~ /usr/include/c++/v1/atomic:991:51: note: in instantiation of member function 'std::__1::__atomic_base<boost::lockfree::detail::tagged_ptr<nova::freelist::freelist_node>, false>::__atomic_base' requested here _LIBCPP_CONSTEXPR atomic(_Tp __d) _NOEXCEPT : __base(__d) {} ^ /wrkdirs/usr/ports/audio/supercollider/work/SuperCollider-Source/server/supernova/sc/../server/../utilities/freelist.hpp:41:9: note: in instantiation of member function 'std::__1::atomic<boost::lockfree::detail::tagged_ptr<nova::freelist::freelist_node> >::atomic' requested here pool_(tagged_ptr(nullptr)) ^ /wrkdirs/usr/ports/audio/supercollider/work/SuperCollider-Source/external_libraries/boost/boost/lockfree/detail/tagged_ptr_ptrcompression.hpp:157:5: note: candidate function operator bool(void) const ^ 1 error generated. ninja: build stopped: subcommand failed. *** Error code 1
Fixed several problems: 1. SUPERNOVA option breaks on 10, labeled it as broken on 10 2. SUPERNOVA was assumed to be false by default, fixed this 3. Added missing dependency XORG=x11 for SUPERNOVA Passes poudriere on 11i386/11amd64/10i386.
Created attachment 185689 [details] patch
** Maintainer timeout expired **
Created attachment 185702 [details] patch + missing BUILD_DEP on booth.
Created attachment 185704 [details] patch Made SUPERNOVA default, because it is default in the project for Linux. Builds fine for 11.1 amd64 and 10.3 i386
Sorry it took me so long to get back to this, because this is not a new release and pre-patch the port builds on 10.3, it should still be buildable on 10.3 post-patch. Can you please recheck the build issue on 10.3, it needs to remain buildable on 10.3.
(In reply to Richard Gallamore from comment #9) The latest patch builds fine on Builds fine for 11.1 amd64 and 10.3 i386.
103i386: Failed: https://poudriere.ultimasbox.com/data/103amd64-test/2017-09-02_20h24m14s/logs/errors/supercollider-3.8.0_2.log 103amd64: Failed: https://poudriere.ultimasbox.com/data/103i386-test/2017-09-02_20h24m15s/logs/errors/supercollider-3.8.0_2.log
Created attachment 186035 [details] patch I forgot that SC was marked "broken" on 10. IMO, fixing the issue itself isn't worth the time. So, I changed the condition: the new option will not be a default where it breaks.
(In reply to Yuri Victorovich from comment #12) Instead of adding all that additional code, it should be OPTIONS_EXCLUDE_FreeBSD_10= SUPERNOVA This will remove the option entirely for OPSYS FreeBSD on all point 10 releases. Also add a comment explaining why. Already made the change it is ready for commit. The maintainer has had no response for a month so will be timeout.
+1
Committed, thanks!
A commit references this bug: Author: ultima Date: Sat Sep 16 02:14:43 UTC 2017 New revision: 449940 URL: https://svnweb.freebsd.org/changeset/ports/449940 Log: * Bump revision for fixing missing / redundant dependencies * New options, HELP and SUPERNOVA, Help Install on-line help text and supernova builds with audio synthesis server * Added license file * Cleanup Makefile PR: 221228 Submitted by: Yuri Victorovich Reviewed by: matthew, mat Approved by: maintainer timeout (1+ month) MFH: 2017Q3 Differential Revision: https://reviews.freebsd.org/D11997 Changes: head/audio/supercollider/Makefile head/audio/supercollider/pkg-plist
Reopening, waiting for MFC approval.