Created attachment 185032 [details] shar QAs: * pourdriere * portlint
@Yuri, for future issues, if you could please detail the versions/archs/options that were tested with poudriere, that helps committers easily determine where they might be able to do more comprehensive testing.
(In reply to Kubilay Kocak from comment #1) Ok!
Created attachment 185255 [details] shar Fixed stripping.
c++ -fstack-protector ir_gui.o ir_utils.o ir_meter.o ir_modeind.o ir_wavedisplay.o -lc -lm -lzita-convolver -lsamplerate -lsndfile `pkg-config --libs gthread-2.0` `pkg-config --libs gtk+-2.0` -shared -z nodelete -o ir_gui.so c++: error: unknown argument: '-z' c++: error: no such file or directory: 'nodelete' gmake[1]: *** [Makefile:51: ir_gui.so] Error 1 gmake[1]: Leaving directory '/wrkdirs/usr/ports/audio/ir-lv2/work/ir.lv2-af1f8ab' ===> Compilation failed unexpectedly. Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to the maintainer. *** Error code 1 Looks like 10.3 clang is too old to build. 11/12 build fine.
Also please change to versioning to the way that was added recently in docs[1] example 15.3. [1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html
I don't get the -z error. What system are you on? What does 'c++ --version' say? For me - 11.1 and # c++ --version FreeBSD clang version 4.0.0 (tags/RELEASE_400/final 297347) (based on LLVM 4.0.0)
Created attachment 185471 [details] shar archive Fixed both problems.
(In reply to Yuri Victorovich from comment #6) Sorry, I made too many assumptions. Part of QA for all new and currently supported ports is to support all tier 1 architectures[1] on all *-RELEASES[2]. This includes 10.3, 11.0, and they should also be buildable on head, aka 12. I'm pretty sure clang on 10.3 was version 3.4. Also I want to add that I didn't forget 11.1, all packages for major releases should be forward compatible for the same major, higher minor release, or until no longer supported in which case would be the next lowest supported minor release. Hope this long explanation helps explain a little bit more of the QA process. [1] https://www.freebsd.org/platforms [2] https://www.freebsd.org/releases
Looks good. Yeah I guess it is just a bug in 3.4 clang.
Well, isn't implemented in 3.4 clang rather.
-z is a gcc extension, so it may or may not be implemented elsewhere.
A commit references this bug: Author: ultima Date: Thu Aug 17 19:53:53 UTC 2017 New revision: 448184 URL: https://svnweb.freebsd.org/changeset/ports/448184 Log: LV2 Impulse response (convolution) plugin (for reverb and cabinet simulation). This fork adds LV2 State extenstion support for proper storing of internal plugin data. IR is a no-latency/low-latency, realtime, high performance signal convolver especially for creating reverb effects. Supports impulse responses with 1, 2 or 4 channels, in any soundfile format supported by libsndfile. WWW: https://github.com/Anchakor/ir.lv2 PR: 221232 Submitted by: Yuri Victorovich (maintainer) Reviewed by: matthew (mentor) Approved by: matthew (mentor) Differential Revision: https://reviews.freebsd.org/D12059 Changes: head/audio/Makefile head/audio/ir-lv2/ head/audio/ir-lv2/Makefile head/audio/ir-lv2/distinfo head/audio/ir-lv2/files/ head/audio/ir-lv2/files/patch-Makefile head/audio/ir-lv2/files/patch-ir.h head/audio/ir-lv2/pkg-descr
(In reply to Yuri Victorovich from comment #11) Thanks for the explanation. Committed, thanks!