Created attachment 185144 [details] shar QAs: * poudriere 11.1 amd64 * portlint * runs fine
Created attachment 185148 [details] shar archive
There are some warnings about at the end of configure, Can you please check them out? configure: WARNING: unrecognized options: --with-qt-includes, --with-qt-libraries, --with-extra-includes, --with-extra-libs Will use the following QT libs: -L/usr/local/lib/qt5 -lQt5Widgets -lQt5Gui -lQt5Core Translation file generation enabled. sed: 1: "qmidiarp_arp.lv2/qmidia ...": extra characters at the end of q command sed: 1: "qmidiarp_lfo.lv2/qmidia ...": extra characters at the end of q command sed: 1: "qmidiarp_seq.lv2/qmidia ...": extra characters at the end of q command Also please strip the libs. ====> Running Q/A tests (stage-qa) Warning: 'lib/lv2/qmidiarp_lfo.lv2/qmidiarp_lfo_ui.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} Warning: 'lib/lv2/qmidiarp_lfo.lv2/qmidiarp_lfo.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} Warning: 'lib/lv2/qmidiarp_seq.lv2/qmidiarp_seq.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} Warning: 'lib/lv2/qmidiarp_seq.lv2/qmidiarp_seq_ui.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} Warning: 'lib/lv2/qmidiarp_arp.lv2/qmidiarp_arp.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} Warning: 'lib/lv2/qmidiarp_arp.lv2/qmidiarp_arp_ui.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Created attachment 185415 [details] shar archive > unstripped libs ... I can't reproduce it. Updated shar in case I fixed this before and the shar was old. > configure warnings about qt-includes, etc These are supplied by USE_QT. They are normally recognized, but they are no harm as long as libs are found ok.
sed commands warnings: I will let the dev know. They are likely BSD vs. Linux problems. For now - just commit as is please.
https://github.com/emuse/qmidiarp/issues/1
There are two changes needed before it is able to commit, * There are two WWW: in the pkg-descr and should only have one. * This port is not make job safe. Please add MAKE_JOBS_UNSAFE= yes. This is probably a problem that upstream needs to fix as well.
Created attachment 185424 [details] shar archive Fixed double WWW. I can't reproduce build multi-cpu build unsafety. Don't see any evidence. What evidence do you see? If you are positive this is the case - then just add that statement. But I rebuilt it 10 times and it finished fine. Even setting MAKE_JOBS_NUMBER=100 doesn't break it.
(In reply to Yuri Victorovich from comment #7) My poudriere build box has 80 vcores and I have it limited to 40 make jobs, half the time half of them fail to build without MAKE_JOBS_UNSAFE. Here are some logs. https://poudriere.ultimasbox.com/data/110amd64-test/2017-08-14_11h03m49s/logs/errors/qmidiarp-0.6.4.log https://poudriere.ultimasbox.com/data/12amd64-test/2017-08-14_13h49m59s/logs/errors/qmidiarp-0.6.4.log https://poudriere.ultimasbox.com/data/12i386-test/2017-08-14_11h03m52s/logs/errors/qmidiarp-0.6.4.log https://poudriere.ultimasbox.com/data/12i386-test/2017-08-14_13h50m00s/logs/errors/qmidiarp-0.6.4.log
Created attachment 185427 [details] shar archive Added MAKE_JOBS_UNSAFE=yes. What does `sysctl hw.model` print on your poudriere server?
(In reply to Yuri Victorovich from comment #9) They are E5-2698V4x2. Thanks, looks good. Can hopefully get to the rest of your new ports this week but, well... 82 bugs new/open with activity in the past week and 45 are new ports. Wonder how many are yours, looks like more than half so that maybe doubtful. Thanks for all your contributions. You are doing a great!
(In reply to Richard Gallamore from comment #10) Thanks! I decided to bring the FreeBSD audio support up to speed, and learn few more things myself. Thank you for committing them! Yuri
One thing that needs to be changed that I keep forgetting. When using GH_TAGNAME and having normal version releases, the proper way to determine the version is, git describe --tags $GH_TAGNAME, in this case the output is qmidiarp-0.6.4-26-g1a15c13. We need to add -26 to DISTVERSIONSUFFIX. I already added it, just letting you know for future. Also, because port is using DISTVERSIONPREFIX/SUFFIX it would be best to just use DISTVERSION for the port version. You don't need to fix, already added and ready for commit.
(In reply to Richard Gallamore from comment #12) Ok!
A commit references this bug: Author: ultima Date: Thu Aug 17 20:00:47 UTC 2017 New revision: 448187 URL: https://svnweb.freebsd.org/changeset/ports/448187 Log: QMidiArp is an advanced MIDI arpeggiator, programmable step sequencer and LFO. It can hold any number of arpeggiator, sequencer, or LFO modules running in parallel. Arpeggiator modules produce sequences depending on the notes sent to their input port, which is typically connected to a keyboard or another sequencer. Step sequencer modules allow you to create simple linear, monophonic and globally transposable sequences similar to the first analog sequencers. MIDI LFO modules independently produce MIDI controller data of adjustable waveform, time resolution, amplitude and duration. A Global Storage Tool can store different setups and switch between them at a given time. It allows you to dynamically combine patterns and LFO wave forms. WWW: http://qmidiarp.sourceforge.net/ PR: 221327 Submitted by: Yuri Victorovich (maintainer) Reviewed by: matthew (mentor), mat Approved by: matthew (mentor) Differential Revision: https://reviews.freebsd.org/D12033 Changes: head/audio/Makefile head/audio/qmidiarp/ head/audio/qmidiarp/Makefile head/audio/qmidiarp/distinfo head/audio/qmidiarp/pkg-descr head/audio/qmidiarp/pkg-plist
Committed, thanks!