Bug 221498 - mail/isync: fix build with LibreSSL
Summary: mail/isync: fix build with LibreSSL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-13 23:09 UTC by Piotr Kubaj
Modified: 2017-08-14 00:09 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments
patch (956 bytes, patch)
2017-08-13 23:09 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2017-08-13 23:09:38 UTC
Created attachment 185376 [details]
patch

Without the attached patch, I get the error during build:
cc  -O2 -pipe  -fstack-protector -fno-strict-aliasing -pipe -W -Wall -Wshadow -Wstrict-prototypes  -pedantic -Wno-overlength-strings  -L/usr/local/lib/db5 -Wl,-rpath,/usr/local/lib -fstack-protector -L/usr/local/lib -L/usr/local/lib -o mbsync main.o sync.o config.o  util.o socket.o driver.o  drv_imap.o drv_maildir.o -ldb -lssl -lcrypto  -lsasl2 -lz                                                                      
socket.o: In function `socket_start_tls':           
socket.c:(.text+0xc6): undefined reference to `X509_STORE_get0_objects'                                  
socket.o: In function `start_tls_p2':               
socket.c:(.text+0x273): undefined reference to `X509_OBJECT_get0_X509'                                   
cc: error: linker command failed with exit code 1 (use -v to see invocation)                             
*** Error code 1                                    


With the attached patch, build passes (also on Poudriere).
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-08-14 00:08:27 UTC
A commit references this bug:

Author: ehaupt
Date: Mon Aug 14 00:07:50 UTC 2017
New revision: 447924
URL: https://svnweb.freebsd.org/changeset/ports/447924

Log:
  Fix build with libressl

  PR:		221498
  Submitted by:	pkubaj@anongoth.pl

Changes:
  head/mail/isync/files/
  head/mail/isync/files/patch-src_socket.c
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2017-08-14 00:09:31 UTC
Good catch, thank you. My test builds didn't spot this since I was testing against the default OpenSSL version.