Bug 221558 - www/selenium: Update to 3.5.0 + fix from previous commit
Summary: www/selenium: Update to 3.5.0 + fix from previous commit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-16 11:07 UTC by Daniel Ylitalo
Modified: 2017-09-04 09:10 UTC (History)
2 users (show)

See Also:
pi: maintainer-feedback-


Attachments
Patch that brings port up to 3.5.0 and address previous issues (4.12 KB, patch)
2017-08-16 11:07 UTC, Daniel Ylitalo
no flags Details | Diff
Patch that brings port up to 3.5.2 (3.26 KB, patch)
2017-08-22 10:57 UTC, Daniel Ylitalo
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Ylitalo 2017-08-16 11:07:00 UTC
Created attachment 185479 [details]
Patch that brings port up to 3.5.0 and address previous issues

Provided patch updates port to 3.5.0 and addresses two things that was forgotten during the last commit when applying my patch.

1) Users being added to UIDs / GIDs wasnt commited

2) pkg-message and files/pkg-message.in got scrambled somehow

(See PR 219031 for previous patch)

Attached patch passes portlint -AC and poudriere testport
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2017-08-16 16:50:12 UTC
testbuilds@work

Sorry for the UID/GID failure!
Comment 2 Daniel Ylitalo 2017-08-22 10:57:59 UTC
Created attachment 185659 [details]
Patch that brings port up to 3.5.2

- Updating patch for 3.5.2 while waiting for maintainer timeout
- Removing the UID/GID part as that has now been commited
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-09-03 15:48:04 UTC
A commit references this bug:

Author: pi
Date: Sun Sep  3 15:47:30 UTC 2017
New revision: 449206
URL: https://svnweb.freebsd.org/changeset/ports/449206

Log:
  www/selenium: update 3.4.0 to 3.5.2

  - submitter becomes maintainer

  PR:		221558
  Submitted by:	Daniel Ylitalo <daniel@blodan.se>
  Approved by:	kaworu@users.sourceforge.jp (maintainer timeout)

Changes:
  head/www/selenium/Makefile
  head/www/selenium/distinfo
  head/www/selenium/files/pkg-message.in
  head/www/selenium/pkg-message
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2017-09-03 15:48:34 UTC
Committed, thanks!
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2017-09-03 15:49:08 UTC
Btw, can you ask upstream for links to their release notes or something similar ?
Comment 6 Daniel Ylitalo 2017-09-04 09:10:23 UTC
They already have release notes on their github page, for 3.5.2 the url is:
https://github.com/SeleniumHQ/selenium/releases/tag/selenium-3.5.2

I can include that in my next update.