Created attachment 185495 [details] libircclient.patch Hello, the current libircclient is obsolète, it uses version 1.7, and it's in 1.9 since some time. I updated it together with adding a SHARED option to port permitting to build the shared lib instead of static lib (i have some personnal projects which needs to use shared lib because they are libs themselves and some symbols are not found in static lib). SHARED is off by default, but could be enabled if needed (default on many Linux distros)
Hello, few notes: - Your patch does not apply cleanly on Makefile - You can use OPTIONS_SUB= yes to manage the PLIST_SUB for you - Why SHARED does no install the static version as well ? - How do you manage ABI version changes ? Is it handled by upstream ?
Hello Julien, thanks for your reply static version is only built when we don't set the SHARED flag, it's in the libircclient compilation recipe There is no ABI version change between 1.7 and 1.9 it's just bugfixes (i ran libircclient on a C++ wrapper in 1.7 on FreeBSD and 1.9 on Archlinux since 2 years without problem) I don't really understand how OPTIONS_SUB can help here, maybe you can help me with this
@julien, i ping you to have an update on this port update
Committed.
A commit references this bug: Author: yuri Date: Sat Mar 21 23:41:27 UTC 2020 New revision: 528888 URL: https://svnweb.freebsd.org/changeset/ports/528888 Log: irc/libircclient: Update 1.7 -> 1.10 PR: 221567 Approved by: jlaffaye (maintainer's timeout; 2.5 years) Changes: head/games/megaglest/Makefile head/irc/libircclient/Makefile head/irc/libircclient/distinfo head/irc/libircclient/pkg-plist