Bug 221874 - security/sudo: Update to 1.8.21.
Summary: security/sudo: Update to 1.8.21.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-28 02:50 UTC by Yasuhiro Kimura
Modified: 2017-08-29 10:39 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (garga)

Attachments
patch file (2.93 KB, patch)
2017-08-28 02:50 UTC, Yasuhiro Kimura 		no flags Details | Diff
updated patch file (3.06 KB, patch)
2017-08-29 06:43 UTC, Yasuhiro Kimura 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2017-08-28 02:50:45 UTC 
Created attachment 185835 [details]
patch file

Update to 1.8.21.
Comment 1 Renato Botelho freebsd_committer freebsd_triage 2017-08-28 12:21:02 UTC 
Bryan,

Can you please validate the fix you did still works with this patch?
Comment 2 Bryan Drewery freebsd_committer freebsd_triage 2017-08-29 03:23:02 UTC 
Please use this instead for the SIGINFO handling:

https://people.freebsd.org/~bdrewery/patch-src_exec__nopty.c

The patch in the bug would work fix the problem, but it does not behave the same
as the original patch.  This version will not forward a ^T but it will properly
forward a kill -INFO (not from ^T).

Yes, the patch is simpler now; only 1 hunk is needed.
Comment 3 Yasuhiro Kimura freebsd_committer freebsd_triage 2017-08-29 06:43:27 UTC 
Created attachment 185858 [details]
updated patch file

Update patch to replace files/patch-src_exec__nopty.c with the one provided in comment #2.

So please commit attached patch instead of original one.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-08-29 10:30:47 UTC 
A commit references this bug:

Author: garga
Date: Tue Aug 29 10:30:34 UTC 2017
New revision: 448901
URL: https://svnweb.freebsd.org/changeset/ports/448901

Log:
  - Update security/sudo to 1.8.21

  PR:		221874
  Submitted by:	Yasuhiro KIMURA <yasu@utahime.org>
  		bdrewery (SIGINFO fix)
  Sponsored by:	Rubicon Communications, LLC (Netgate)

Changes:
  head/security/sudo/Makefile
  head/security/sudo/distinfo
  head/security/sudo/files/patch-src_exec__nopty.c
  head/security/sudo/pkg-plist
Comment 5 Renato Botelho freebsd_committer freebsd_triage 2017-08-29 10:39:25 UTC 
FYI, I opened a bug upstream and sent the patch

https://bugzilla.sudo.ws/show_bug.cgi?id=796