Bug 221923 - provide a base/port option for net-mgmt/tcpreplay
Summary: provide a base/port option for net-mgmt/tcpreplay
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-29 21:37 UTC by Dan Langille
Modified: 2017-08-31 19:29 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
patch without options (524 bytes, text/plain)
2017-08-29 21:37 UTC, Dan Langille 		no flags Details
patch with base/port options (917 bytes, patch)
2017-08-30 16:58 UTC, Dan Langille 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Langille freebsd_committer freebsd_triage 2017-08-29 21:37:41 UTC 
Created attachment 185900 [details]
patch without options

FYI, I plan to submit a patch to provide a base/port option for net-mgmt/tcpreplay to 
use either libpcap from base or from net/libpcap

The attached patch works, but provides no option.

If you're keen to do the work yourself, great.  Otherwise, I'll complete the work soon.

The need came about because one of our folks needed the newer libpcap to avoid a bug.

Thank you.
Comment 1 Dan Langille freebsd_committer freebsd_triage 2017-08-30 16:58:16 UTC 
Created attachment 185932 [details]
patch with base/port options

I've tested this patch:

* with nothing set (builds with base)
* with base set
* with port set

Expected results were obtained.  e.g. 

root@103R-working:~ # tcprewrite  --version
tcprewrite version: 4.2.6 (build git:)
Copyright 2013-2017 by Fred Klassen <tcpreplay at appneta dot com> - AppNeta
Copyright 2000-2012 by Aaron Turner <aturner at synfin dot net>
The entire Tcpreplay Suite is licensed under the GPLv3
Cache file supported: 04
Compiled against libdnet: 1.12
Compiled against libpcap: 1.4.0
64 bit packet counters: enabled
Verbose printing via tcpdump: enabled
Fragroute engine: enabled
root@103R-working:~ #
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2017-08-30 19:23:55 UTC 
Thanks for the patch. LGTM, please feel free to commit.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-08-30 19:32:08 UTC 
A commit references this bug:

Author: dvl
Date: Wed Aug 30 19:32:01 UTC 2017
New revision: 448998
URL: https://svnweb.freebsd.org/changeset/ports/448998

Log:
  Add base/port options for libpcap

  PR:		221923
  Approved by:	ehaupt (maintainer)

Changes:
  head/net-mgmt/tcpreplay/Makefile
Comment 4 Dan Langille freebsd_committer freebsd_triage 2017-08-30 19:32:33 UTC 
Done.  Thank you.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-08-31 19:29:58 UTC 
A commit references this bug:

Author: feld
Date: Thu Aug 31 19:29:19 UTC 2017
New revision: 449051
URL: https://svnweb.freebsd.org/changeset/ports/449051

Log:
  MFH: r448998 r449000 r449020

  Add base/port options for libpcap

  PR:		221923
  Approved by:	ehaupt (maintainer)

  Correctly define the _DESC values

  Reported by:	ehaupt,mat

  Fix OPTIONS_SINGLE logic. The two options (LIBPCAP_BASE and LIBPCAP_PORTS) need
  to be mutually exclusive.

  If LIBPCAP_BASE is selected, make sure the binary is linked against the libpcap
  from base, even if net/libpcap is present.

  Bump PORTREVISION to make sure the OPTIONS change is tracked.

  Reported by:	jbeich

  Approved by:	ports-secteam (with hat)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/net-mgmt/tcpreplay/Makefile