Bug 221938 - graphics/potrace: Update to 1.15, add support for building libpotrace
Summary: graphics/potrace: Update to 1.15, add support for building libpotrace
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-08-30 13:37 UTC by Piotr Smyrak
Modified: 2018-03-08 08:56 UTC (History)
4 users (show)

See Also:

Attachments
port patch (2.53 KB, patch)
2017-08-30 13:37 UTC, Piotr Smyrak 		no flags Details | Diff
port patch mk. 2 (2.40 KB, patch)
2017-09-02 21:39 UTC, Piotr Smyrak 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Smyrak 2017-08-30 13:37:54 UTC 
Created attachment 185921 [details]
port patch

Here's a patch that upgrades the port to recently released new version 1.15. 

Adds support for building library.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-08-31 12:33:23 UTC 
(In reply to Piotr Smyrak from comment #0)
I'm curious why we have two ports graphics/potrace and graphics/libpotrace? Now that graphics/potrace also builds libpotrace can't they be one port?
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2017-08-31 12:36:52 UTC 
Before I forget, please use options helpers. This

+.include <bsd.port.options.mk>
...
+.if ${PORT_OPTIONS:MLIBRARY}
+USE_LDCONFIG+=	yes
+USES+=		libtool
+INSTALL_TARGET=	install-strip
+PLIST_SUB+=	LIBRARY=""
+.else
+PLIST_SUB+=	LIBRARY="@comment "
+.endif

can be

OPTIONS_SUB=	yes
LIBRARY_USE=	LDCONFIG=yes
LIBRARY_USES=	libtool
LIBRARY_INSTALL_TARGET=	install-strip
Comment 3 Piotr Smyrak 2017-08-31 17:26:03 UTC 
Thanks for the tips.

I was in contact with hrs@ and we agreed to merge them, when graphics/potrace gets library support. So I see this patch as a first stage.
Comment 4 Piotr Smyrak 2017-09-02 21:39:41 UTC 
Created attachment 186006 [details]
port patch mk. 2
Comment 5 Piotr Smyrak 2017-11-02 18:01:02 UTC 
Any chance to get this integrated?
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2018-03-08 08:55:22 UTC 
Committed with changes.
Sorry for the delay.
Thank you for the update!
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-03-08 08:56:08 UTC 
A commit references this bug:

Author: yuri
Date: Thu Mar  8 08:55:15 UTC 2018
New revision: 463879
URL: https://svnweb.freebsd.org/changeset/ports/463879

Log:
  graphics/potrace: Update to 1.15

  Port changes:
  * Changed DISTVERSION
  * Simplified MASTER_SITES
  * Added LIBRARY DOCS options
  * Moved plist into pkg-plist
  * Added CONFLICTS

  PR:		221938
  Submitted by:	Piotr Smyrak <ps.ports@smyrak.com> (maintainer)
  Approved by:	tcberner (mentor, implicit)

Changes:
  head/graphics/potrace/Makefile
  head/graphics/potrace/distinfo
  head/graphics/potrace/pkg-plist