Bug 222041 - math/pari: fix install without thread
Summary: math/pari: fix install without thread
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-04 00:49 UTC by Anton Yuzhaninov
Modified: 2017-11-22 18:56 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
Fix build with threads disabled (1.42 KB, patch)
2017-09-04 00:49 UTC, Anton Yuzhaninov
no flags Details | Diff
patch (1.68 KB, patch)
2017-09-04 02:51 UTC, Yuri Victorovich
yuri: maintainer-approval+
Details | Diff
patch (2.26 KB, patch)
2017-09-04 03:58 UTC, Yuri Victorovich
yuri: maintainer-approval+
Details | Diff
patch (2.25 KB, patch)
2017-09-04 04:00 UTC, Yuri Victorovich
yuri: maintainer-approval+
Details | Diff
patch (2.25 KB, patch)
2017-09-04 04:02 UTC, Yuri Victorovich
yuri: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Yuzhaninov 2017-09-04 00:49:12 UTC
Created attachment 186048 [details]
Fix build with threads disabled

When threads are disabled (PTHREADS=off MPI=off) math/pari install fail with an error:
/usr/bin/strip /tmp/p/usr/ports/math/pari/work/stage/usr/local/lib/libpari-gmp*.so.*
strip: open /tmp/p/usr/ports/math/pari/work/stage/usr/local/lib/libpari-gmp*.so.* failed: No such file or directory

Attached patch fixes it.

Also please consider removing MAKE_JOBS_UNSAFE. At least on my system it builds whith make jobs enabled.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2017-09-04 02:51:30 UTC
Created attachment 186052 [details]
patch

Thanks for your patch!

I've got a simpler patch. There's no need for -gmp suffix.

Cheers!
Yuri

~ builds in poudriere 11.1 amd64
Comment 2 Anton Yuzhaninov 2017-09-04 03:09:01 UTC
It is up to you, but I prefer to keep patches to upstream files small. If Configure will be changed by upstream, you will have to update a patch.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-09-04 03:20:13 UTC
> It is up to you, but I prefer to keep patches to upstream files small. If Configure will be changed by upstream, you will have to update a patch.

Ok. I will raise this in their ML. But I see -gmp as serving no purpose on FreeBSD. Rather, it hurts because of precisely this issue.

Cheers!
Yuri
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2017-09-04 03:58:44 UTC
Created attachment 186053 [details]
patch

I combined both new and old patches for Configure into one command in Makefile. One-liner patches should be preferably in the Makefile. I will ask them to kill both suffixes.

Yuri
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-09-04 04:00:15 UTC
Created attachment 186054 [details]
patch
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2017-09-04 04:02:15 UTC
Created attachment 186055 [details]
patch
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-22 18:55:49 UTC
Thank you for your submission!
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-11-22 18:56:34 UTC
A commit references this bug:

Author: yuri
Date: Wed Nov 22 18:55:30 UTC 2017
New revision: 454700
URL: https://svnweb.freebsd.org/changeset/ports/454700

Log:
  math/pari: Fixed install without threads; Removed MAKE_JOBS_UNSAFE; Added LICENSE_FILE

  PR:		222041
  Submitted by:	Anton Yuzhaninov <citrin+pr@citrin.ru>
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D13174

Changes:
  head/math/pari/Makefile
  head/math/pari/files/
  head/math/pari/pkg-plist