Created attachment 186121 [details] [patch] catch up to .pc.in change The 1.8.1 update regressed the jsoncpp.pc file: % pkgconf --cflags jsoncpp -I@CMAKE_INSTALL_FULL_INCLUDEDIR@ The jsoncpp.pc.in file was changed to add _FULL for some reason.
Comment on attachment 186121 [details] [patch] catch up to .pc.in change Thanks!
(In reply to Yuri Victorovich from comment #1) Try setting 'maintainer-approval' for the patch attachment to '+'. I'm not sure that setting 'maintainer-feedback' to '+' on the main page for the bug helps to get it committed.
(In reply to John Hein from comment #2) It doesn't work for me on attachment.
Comment on attachment 186121 [details] [patch] catch up to .pc.in change Yuri, Do you have more details about how "it didn't work". I set 'maintainer-approval' on the patch to '?'. Maybe you can't change it to '+' unless it's set to '?'.
(In reply to John Hein from comment #4) > Maybe you can't change it to '+' unless it's set to '?'. Looks like this is exactly the case.
+1 here, having the same issue, breaking anything which depends on jsoncpp (in my case, stuff not in ports). Patch looks good.
*** Bug 222422 has been marked as a duplicate of this bug. ***
A commit references this bug: Author: sunpoet Date: Wed Oct 4 10:56:17 UTC 2017 New revision: 451212 URL: https://svnweb.freebsd.org/changeset/ports/451212 Log: Fix jsoncpp.pc - Bump PORTREVISION for package change PR: 222104 Submitted by: John Hein <z7dr6ut7gs@snkmail.com> Approved by: Yuri Victorovich <yuri@rawbw.com> (maintainer) Changes: head/devel/jsoncpp/Makefile
Committed. Thanks!
MARKED AS SPAM