Bug 222235 - [PATCH]net-im/tox: 0.1.8_1,1 build failed
Summary: [PATCH]net-im/tox: 0.1.8_1,1 build failed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thierry Thomas
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-09-11 18:43 UTC by Ivan Rozhuk
Modified: 2017-11-28 20:44 UTC (History)
2 users (show)

See Also:


Attachments
remove #include <alloca.h> (460 bytes, patch)
2017-09-11 18:43 UTC, Ivan Rozhuk
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2017-09-11 18:43:52 UTC
Created attachment 186269 [details]
remove #include <alloca.h>

...
/usr/bin/c++   -I/usr/local/include -I/usr/local/include/opus -I/usr/local/include/opencv -O2 -msse2 -msse3 -mssse3 -msse4.1 -pipe -fstack-protector -fno-strict-aliasing -std=c++11 -Wall -Wextra -Weverything -Wno-cast-align -Wno-conversion -Wno-covered-switch-default -Wno-disabled-macro-expansion -Wno-documentation-deprecated-sync -Wno-format-nonliteral -Wno-missing-field-initializers -Wno-missing-prototypes -Wno-padded -Wno-parentheses -Wno-return-type -Wno-sign-compare -Wno-sign-conversion -Wno-tautological-constant-out-of-range-compare -Wno-type-limits -Wno-undef -Wno-unreachable-code -Wno-unused-macros -Wno-unused-parameter -Wno-vla -Wno-c++11-compat -Wno-c++11-extensions -Wno-c++11-narrowing -Wno-c99-extensions -Wno-narrowing -Wno-old-style-cast -Wno-variadic-macros -Wno-vla-extension -isystem /usr/local/include -isystem /usr/local/include/opus -isystem /usr/local/include -isystem /usr/local/include -isystem /usr/local/include -isystem /usr/local/include -isystem /usr/local/include -isystem /usr/local/include -O2 -msse2 -msse3 -mssse3 -msse4.1 -pipe -fstack-protector -fno-strict-aliasing -MD -MT CMakeFiles/av_test.dir/testing/av_test.c.o -MF CMakeFiles/av_test.dir/testing/av_test.c.o.d -o CMakeFiles/av_test.dir/testing/av_test.c.o -c testing/av_test.c
c++: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated]
testing/av_test.c:26:9: warning: macro name is a reserved identifier 
...
In file included from testing/av_test.c:48:
In file included from testing/../toxcore/network.h:33:
testing/../toxcore/ccompat.h:33:10: fatal error: 'alloca.h' file not found
#include <alloca.h>
         ^~~~~~~~~~
13 warnings and 1 error generated.
ninja: build stopped: subcommand failed.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2017-09-13 17:42:21 UTC
(In reply to rozhuk.im from comment #0)

I'm sorry, but I cannot reproduce this error.
Could you please give more context?
Comment 2 Ivan Rozhuk 2017-09-14 08:41:02 UTC
(In reply to Thierry Thomas from comment #1)

May that happen because I have: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210505

Any way, I have no alloca.h in my system.
Comment 3 Ivan Rozhuk 2017-11-28 16:22:35 UTC
Probably this because I have some developer tools/ports installed, like with https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221881

This patch is safe and does not break anything.
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2017-11-28 20:43:38 UTC
Thanks for the notification!

Remark: since only one file is concerned, I prefer patch it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-11-28 20:44:21 UTC
A commit references this bug:

Author: thierry
Date: Tue Nov 28 20:43:38 UTC 2017
New revision: 455075
URL: https://svnweb.freebsd.org/changeset/ports/455075

Log:
  Fix the build in some cases.

  PR:		222235
  Submitted by:	rozhuk.im (at) gmail.com

Changes:
  head/net-im/tox/Makefile
  head/net-im/tox/files/patch-toxcore_ccompat.h