Bug 222318 - [NEW PORT] mail/roundcube-yubikey_auth: YubiKey auth for Roundcube
Summary: [NEW PORT] mail/roundcube-yubikey_auth: YubiKey auth for Roundcube
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-14 06:42 UTC by Vidar Karlsen
Modified: 2018-07-27 05:15 UTC (History)
2 users (show)

See Also:


Attachments
shar for mail/roundcube-yubikey_auth (2.88 KB, text/plain)
2017-09-14 06:42 UTC, Vidar Karlsen
no flags Details
Flavorized shar, ref. PR 227715 (2.96 KB, text/plain)
2018-05-02 23:22 UTC, Vidar Karlsen
no flags Details
Working shar for g20180404 (commit 383bbb3) (3.31 KB, text/plain)
2018-07-26 20:31 UTC, Vidar Karlsen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vidar Karlsen 2017-09-14 06:42:31 UTC
Created attachment 186364 [details]
shar for mail/roundcube-yubikey_auth

This plugin adds the option to use a YubiKey as second-factor
authentication.

The YubiKey is a USB key emulating a generic keyboard and making
use of one-time passwords to provide two-factor authentication.

WWW: https://github.com/northox/roundcube-yubikey-plugin


portlint: looks fine
poudriere testport: ok

It uses php-curl to talk to the Yubico servers. Roundcube itself doesn't require php-curl, I therefore set USE_PHP=curl to make sure it gets pulled in.
Comment 1 Vidar Karlsen 2018-05-02 23:22:53 UTC
Created attachment 193011 [details]
Flavorized shar, ref. PR 227715

The existing Roundcube plugins were flavorized in PR 227715 / changeset 468851.
This new shar is flavorized the same way.
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2018-07-26 01:28:38 UTC
Thanks for the port, testbuilds@work

Is there a reason not to use the most recent commit on github ?

It's at 383bbb3 from 20180403 ?
Comment 3 Vidar Karlsen 2018-07-26 07:13:57 UTC
It's only using an old commit because the PR is that old. :)
If the commit from 20180403 works fine, we should use that.
I can test the newest one later today.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2018-07-26 17:42:30 UTC
testbuild with the newer version after fixing plist looks fine. Please tell as soon as your run-tests were sucessful.
Comment 5 Vidar Karlsen 2018-07-26 20:31:38 UTC
Created attachment 195485 [details]
Working shar for g20180404 (commit 383bbb3)

It didn't work out of the box due to renamed dir, a renamed file and a renamed class (which also renames a config variable).

This shar for 383bbb3 works, I've tested it on a live roundcube-php71-1.3.6,1.

The install instructions in the upstream README.md are wrong, so I added a REINPLACE_CMD to correct the path and config variable. pkg-descr is updated to reflect this change.

The label element on the login screen is also somehow messed up in the newest commits. I just hardcoded that for now, as it doesn't need to be dynamic and at least it looks better this way.
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2018-07-27 05:15:05 UTC
Committed, thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-07-27 05:15:43 UTC
A commit references this bug:

Author: pi
Date: Fri Jul 27 05:14:52 UTC 2018
New revision: 475412
URL: https://svnweb.freebsd.org/changeset/ports/475412

Log:
  New port: mail/roundcube-yubikey_auth

  This plugin adds the option to use a YubiKey as second-factor
  authentication.

  The YubiKey is a USB key emulating a generic keyboard and make
  use of One-time Passwords to provide two factor authentication.

  Activate the plugin  by adding the following to Roundcube's
  config/config.inc.php:
  $config['plugins'] = array('roundcube_yubikey_authentication');

  WWW: https://github.com/northox/roundcube-yubikey-plugin

  PR:		222318
  Submitted by:	Vidar Karlsen <vidar@karlsen.tech>

Changes:
  head/mail/Makefile
  head/mail/roundcube-yubikey_auth/
  head/mail/roundcube-yubikey_auth/Makefile
  head/mail/roundcube-yubikey_auth/distinfo
  head/mail/roundcube-yubikey_auth/pkg-descr
  head/mail/roundcube-yubikey_auth/pkg-plist