Bug 222573 - print/pdftk: requires lang/gcc6 (strictly and only)
Summary: print/pdftk: requires lang/gcc6 (strictly and only)
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2017-09-24 19:30 UTC by Jan Beich
Modified: 2017-11-26 20:44 UTC (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-09-24 19:30:39 UTC
=======================<phase: configure      >============================
===>   pdftk-2.02_6 depends on executable: gmake - found
===>   pdftk-2.02_6 depends on executable: gcc7 - found
===>   pdftk-2.02_6 depends on file: /usr/local/bin/as - found
===>  Configuring for pdftk-2.02_6

Can not find gcj7
Please rebuild gcc7 with java support

*** Error code 1
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2017-09-24 19:42:00 UTC
GCC 7's release notes say "The GCC Java frontend and associated libjava runtime library have been removed from GCC".
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-09-24 20:16:55 UTC
A commit references this bug:

Author: jbeich
Date: Sun Sep 24 20:16:01 UTC 2017
New revision: 450549
URL: https://svnweb.freebsd.org/changeset/ports/450549

Log:
  print/pdftk: decouple from default GCC version

  Only lang/gcc6 still supports JAVA option.

  PR:		222573
  Reported by:	rakuco
  Approved by:	portmgr blanket

Changes:
  head/print/pdftk/Makefile
Comment 3 Jan Beich freebsd_committer freebsd_triage 2017-09-24 20:17:47 UTC
Leaving open. lang/gcc6 maybe removed in future. Someone needs to contact upstream if they aren't already aware.
Comment 4 Gerald Pfeifer freebsd_committer freebsd_triage 2017-09-24 20:18:15 UTC
Yes, and the patch I submitted for PR 222542 had the following hunk
which I thought addressed this?

Index: print/pdftk/Makefile
===================================================================
--- print/pdftk/Makefile	(revision 450476)
+++ print/pdftk/Makefile	(working copy)
@@ -16,7 +16,7 @@
 # Get GCC version suffix without the dot in USE_GCC
 CSUFF=		${_USE_GCC:S/.//}
 
-USE_GCC=	yes
+USE_GCC=	6	# Only GCC 6 provides Java (GCJ and libgcj).
 USES=		iconv gmake zip
 
 # gcj/libgcj don't exist on some platforms
Comment 5 Gerald Pfeifer freebsd_committer freebsd_triage 2017-09-24 20:20:07 UTC
(In reply to Jan Beich from comment #3)
> Leaving open. lang/gcc6 maybe removed in future. Someone needs to contact
> upstream if they aren't already aware.

mat@ and me discussed this already, and nailing this pdftk to GCC 6
is the only realistic option we see.

Now, I am still confused why what I submitted as part of my patch did
not do the job.  Or perhaps it was not applied?
Comment 6 Jan Beich freebsd_committer freebsd_triage 2017-09-24 20:35:06 UTC
(In reply to Gerald Pfeifer from comment #5)
> Now, I am still confused why what I submitted as part of my patch did
> not do the job.  Or perhaps it was not applied?

Apologies, I've missed it. My testing was based on hacked Mk/bsd.default-versions.mk to quickly test gcc6 vs. gcc7 between different jails (11.0 vs. 11.1 to be specific).

For print/pdftk changing from "yes" to "6" didn't need to wait for the default to change. While USE_GCC machinery doesn't support "less or equal" no other version has JAVA, anymore. That said, your comment still looks useful.
Comment 7 Jan Beich freebsd_committer freebsd_triage 2017-09-24 20:39:37 UTC
Another case for fixing now was to fix the port for users with DEFAULT_VERSIONS += gcc=7 or DEFAULT_VERSIONS += gcc=5.
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-09-24 20:48:20 UTC
A commit references this bug:

Author: jbeich
Date: Sun Sep 24 20:47:48 UTC 2017
New revision: 450550
URL: https://svnweb.freebsd.org/changeset/ports/450550

Log:
  print/pdftk: add inline comment for r450549

  PR:		222573
  Submitted by:	gerald
  Pointy hat to:	jbeich

Changes:
  head/print/pdftk/Makefile
Comment 9 Gerald Pfeifer freebsd_committer freebsd_triage 2017-09-24 21:00:00 UTC
Thank you, Jan.

I think there is little print/pdftk can do about this (= GCC dropping
gcj/libgcj with version 7), so closing this report.
Comment 10 vali gholami 2017-11-26 20:44:48 UTC
MARKED AS SPAM