Created attachment 186805 [details] beta4
Created attachment 186872 [details] beta5
Is this the Big Change? The one that changes add-on interface, unconditionally enables multi-process, etc?
(In reply to Andriy Gapon from comment #2) Yes[1]. Addon SDK and many deprecated features are gone in FF57, so extensions.legacy.enabled=true won't be of much help. To keep users from running away (to ESR52, Chrome, etc) FF57 will also have new UI (aka Photon) and new CSS engine (aka Stylo). Good luck testing! Note, Stylo is currently broken on i386[2]. [1] https://wiki.mozilla.org/Add-ons/Firefox57 [2] https://lists.freebsd.org/pipermail/freebsd-gecko/2017-September/007606.html
testbuild on 11.1@work
Fails with make: don't know how to make check-sanity. Stop Full log see http://people.freebsd.org/~pi/logs/firefox-57.0.b5,1.log
(In reply to Kurt Jaeger from comment #5) How did you apply the patch? I can't reproduce: $ poudriere ports -l | fgrep default default portsnap 2017-10-03 23:37:30 /poudriere/ports/default $ cd /poudriere/ports/default $ patch -Efsp1 -i /path/to/ff57.diff $ poudriere testport -j 103amd64 www/firefox Perhaps, you've bumped into a poudriere bug.
Created attachment 186941 [details] beta6
(In reply to Kurt Jaeger from comment #5) Marco points in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220058#c8 to https://github.com/freebsd/poudriere/issues/451 which explains the problem with check-sanity: If a file of a port is mode 600 (can happen with svn patch!), the check fails, with poudriere-devel. I'm testbuilding again right now.
Testbuild was successful, binary runs (new annoying icons in the urlbar 8-(
Created attachment 187066 [details] beta7
beta{6,7} build and run fine on 12.0/amd64 with SNDIO=on
Testbuild of beta7 was successful, binary runs on 11.1a. I had 2-3 tab crashes already with b6 or b7 -- isn't that too often ?
What does Compositing and Audio Backend in about:support say? Can you check if the crashes are related to Stylo via layout.css.servo.enabled or multi-process windows via browser.tabs.remote.autostart.2 disable in about:config ? And try to get backtrace of the crashed process: for non-debug symbols define STRIP= (empty) or select either DTRACE or PROFILE, for debug symbols set CFLAGS+=-g + STRIP= (empty) or just select DEBUG.
Created attachment 187135 [details] beta8
(In reply to Jan Beich from comment #13) Compositing: Basic Audio Backend: alsa layout.css.servo.enabled: true browser.tabs.remote.autostart.2: true (modified) I'll rebuild with beta8 with all the options requested and report back.
(In reply to Kurt Jaeger from comment #15) With b8: Compositing: Sndio Audio Backend: alsa layout.css.servo.enabled: true browser.tabs.remote.autostart.2: true (modified) Now I need a crash 8-}
Created attachment 187228 [details] beta9 Building on i386 now requires the patch in bug 223047.
testbuild on 11.1a done, runs fine. waiting for crashes 8-}
Created attachment 187315 [details] beta10
Created attachment 187320 [details] beta10 (rebased after ports r452499)
Had some crashes with b8 but didn't have time to investigate: Gdk:ERROR:gdkwindow-x11.c:5165:create_moveresize_window: assertion failed: (mv_resize->moveresize_emulation_window == NULL) frame #11: 0x0000000806426ff1 libxul.so`nsWindow::BeginMoveDrag(mozilla::WidgetMouseEvent*) + 369 frame #12: 0x0000000805273fe1 libxul.so`nsGlobalWindow::BeginWindowMove(mozilla::dom::Event&, mozilla::Element*, nsGlobalWindow::BeginWindowMove::ErrorResult&) + 209 frame #13: 0x00000008058bc4e3 libxul.so`nsGlobalWindow* mozilla::dom::WindowBinding::beginWindowMove(JSContext*, JS::Handle<JSObject*>(JSJitMethodCallArgs const&) + 611 frame #14: 0x00000008058b7d70 libxul.so`mozilla::dom::WindowBinding::genericMethod(JSContext*, unsigned int, JS::Value*) + 464 No crashes with b9 or b10 so far.
Created attachment 187407 [details] beta11
Created attachment 187456 [details] beta11 (rebased after ports r452837)
make patch fails for files/patch-bug1401573 and has those messages: ===> Applying FreeBSD patches for firefox-57.0.b11_3,1 No such line 326 in input file, ignoring No such line 93 in input file, ignoring No such line 5308 in input file, ignoring
Created attachment 187510 [details] beta12
(In reply to Kurt Jaeger from comment #24) > ===> Applying FreeBSD patches for firefox-57.0.b11_3,1 > No such line 326 in input file, ignoring > No such line 93 in input file, ignoring > No such line 5308 in input file, ignoring These are harmless (some context lines are different) and are only reported by BSD patch (i.e., since base r253689).
patch warnings also affect other versions: ===> Applying FreeBSD patches for firefox-56.0.2_3,1 No such line 326 in input file, ignoring No such line 93 in input file, ignoring ===> Applying FreeBSD patches for firefox-esr-52.4.1_1,1 No such line 274 in input file, ignoring ===> Applying FreeBSD patches for libxul-45.9.0_6 No such line 72 in input file, ignoring No such line 327 in input file, ignoring No such line 751 in input file, ignoring No such line 442 in input file, ignoring No such line 1363 in input file, ignoring
(In reply to Tobias Kortkamp from comment #21) So the crashes I had were a known problem [1]. It happens on some esoteric WMs (in my case cwm) when you double-click in the empty space next to the tab bar. Apparently I sometimes accidentally do this. Applying the fix [2,3] to the port solves the problem for me. IIUC it won't be part of Firefox 57. Any chance that we can include it on FreeBSD anyway? I think there might be a disproportionate amount of FreeBSD users that use alternative WMs when compared to Linux... But maybe that is my own bias talking :-) [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1186967 [2] https://hg.mozilla.org/mozilla-central/rev/8a595cffab11 [3] https://pkg.tobik.me/patches/firefox-bug1186967.diff
A commit references this bug: Author: jbeich Date: Sat Oct 28 15:42:22 UTC 2017 New revision: 453059 URL: https://svnweb.freebsd.org/changeset/ports/453059 Log: gecko: double-click on tab bar crashfix for some WMs Obtained from: upstream (Firefox 58) PR: 222693 Submitted by: tobik MFH: 2017Q4 Changes: head/mail/thunderbird/Makefile head/mail/thunderbird/files/patch-bug1186967 head/www/firefox/Makefile head/www/firefox/files/patch-bug1186967 head/www/firefox-esr/Makefile head/www/firefox-esr/files/patch-bug1186967 head/www/seamonkey/Makefile head/www/seamonkey/files/patch-bug1186967
Created attachment 187598 [details] beta13
Created attachment 187676 [details] beta14
Created attachment 187784 [details] beta14 (rebased after ports r453592)
Created attachment 187810 [details] rc1
testbuild@work
testbuild done on 11.1a, test-runs fine.
Created attachment 187898 [details] rc3
Created attachment 187925 [details] rc3 (rebased after ports r454000)
MFH to 2017Q4 would violate POLA per bug 221916 and bug 222859. Let's detach.
Created attachment 187967 [details] rc4 rc4 may be final, given it was copied to /releases directory. Changes since rc3: https://hg.mozilla.org/releases/mozilla-release/rev/a5a689f01f0c https://hg.mozilla.org/releases/mozilla-release/rev/8deb291f300b https://hg.mozilla.org/releases/mozilla-release/rev/74203b7f9e04 https://hg.mozilla.org/releases/mozilla-release/rev/3702966a64c8
Will miss package build tonight (at 01:00 UTC, each 2 days) as I'm waiting on upstream to publish security advisory to figure out the remaining commits to backport to FF56 (for 2017Q4).
A commit references this bug: Author: jbeich Date: Tue Nov 14 19:04:45 UTC 2017 New revision: 454194 URL: https://svnweb.freebsd.org/changeset/ports/454194 Log: www/firefox: update to 57.0 (marketed as "Firefox Quantum") Not a MFH candidate due to POLA violation per redesigned UI, broken legacy addons and auto-reviewed new addons. Changes: https://www.mozilla.org/firefox/57.0/releasenotes/ PR: 222693 Tested by: pi, tobik, TrueOS Changes: head/Mk/Uses/gecko.mk head/www/firefox/Makefile head/www/firefox/distinfo head/www/firefox/files/patch-a-bug1399540 head/www/firefox/files/patch-bug1261175 head/www/firefox/files/patch-bug1325923 head/www/firefox/files/patch-bug1343147 head/www/firefox/files/patch-bug1355576 head/www/firefox/files/patch-bug1365894 head/www/firefox/files/patch-bug1366420 head/www/firefox/files/patch-bug1369561 head/www/firefox/files/patch-bug1370497 head/www/firefox/files/patch-bug1375146 head/www/firefox/files/patch-bug1377587 head/www/firefox/files/patch-bug1381761 head/www/firefox/files/patch-bug1383019 head/www/firefox/files/patch-bug1384121 head/www/firefox/files/patch-bug1384701 head/www/firefox/files/patch-bug1386887 head/www/firefox/files/patch-bug1386957 head/www/firefox/files/patch-bug1387799 head/www/firefox/files/patch-bug1387811 head/www/firefox/files/patch-bug1387845 head/www/firefox/files/patch-bug1393283 head/www/firefox/files/patch-bug1394031 head/www/firefox/files/patch-bug1394265 head/www/firefox/files/patch-bug1394530 head/www/firefox/files/patch-bug1395138 head/www/firefox/files/patch-bug1397811 head/www/firefox/files/patch-bug1399922 head/www/firefox/files/patch-bug1400003 head/www/firefox/files/patch-bug1400554 head/www/firefox/files/patch-bug1401339 head/www/firefox/files/patch-bug1401573 head/www/firefox/files/patch-bug1401804 head/www/firefox/files/patch-bug1402363 head/www/firefox/files/patch-bug1402442 head/www/firefox/files/patch-bug1402876 head/www/firefox/files/patch-bug1402896 head/www/firefox/files/patch-bug1402966 head/www/firefox/files/patch-bug1403646 head/www/firefox/files/patch-bug1404324 head/www/firefox/files/patch-bug1404636 head/www/firefox/files/patch-bug1404910 head/www/firefox/files/patch-bug1406154 head/www/firefox/files/patch-bug1406398 head/www/firefox/files/patch-bug1406750 head/www/firefox/files/patch-bug1407032 head/www/firefox/files/patch-bug1407375 head/www/firefox/files/patch-bug1407740 head/www/firefox/files/patch-bug1407751 head/www/firefox/files/patch-bug1408005 head/www/firefox/files/patch-bug1408412 head/www/firefox/files/patch-bug1408782 head/www/firefox/files/patch-bug1408990 head/www/firefox/files/patch-bug1409680 head/www/firefox/files/patch-bug1411458 head/www/firefox/files/patch-bug1412252 head/www/firefox/files/patch-bug847568 head/www/firefox/files/patch-build-pgo-profileserver.py head/www/firefox/files/patch-servo17934 head/www/firefox/files/patch-servo17969 head/www/firefox/files/patch-servo18046 head/www/firefox/files/patch-servo18126 head/www/firefox-i18n/Makefile head/www/firefox-i18n/distinfo
Thank you for testing!
A commit references this bug: Author: jbeich Date: Mon Nov 27 17:24:11 UTC 2017 New revision: 454972 URL: https://svnweb.freebsd.org/changeset/ports/454972 Log: MFH: r453059 gecko: double-click on tab bar crashfix for some WMs Obtained from: upstream (Firefox 58) PR: 222693 Submitted by: tobik Approved by: ports-secteam (feld) Changes: _U branches/2017Q4/ branches/2017Q4/mail/thunderbird/Makefile branches/2017Q4/mail/thunderbird/files/patch-bug1186967 branches/2017Q4/www/firefox/Makefile branches/2017Q4/www/firefox/files/patch-bug1186967 branches/2017Q4/www/firefox-esr/Makefile branches/2017Q4/www/firefox-esr/files/patch-bug1186967 branches/2017Q4/www/seamonkey/Makefile branches/2017Q4/www/seamonkey/files/patch-bug1186967
A commit references this bug: Author: jbeich Date: Wed Nov 29 17:15:24 UTC 2017 New revision: 455125 URL: https://svnweb.freebsd.org/changeset/ports/455125 Log: www/firefox: update to 57.0.1 Changes: https://www.mozilla.org/firefox/57.0.1/releasenotes/ Changes: https://hg.mozilla.org/releases/mozilla-release/pushloghtml?startdate=2017-11-14&enddate=2017-11-30 PR: 222693 Changes: head/www/firefox/Makefile head/www/firefox/distinfo head/www/firefox-i18n/Makefile head/www/firefox-i18n/distinfo