Bug 222722 - print/pdflib: under __POWERPC__ it's build looks for MacOS 9 headers and so fails to build
Summary: print/pdflib: under __POWERPC__ it's build looks for MacOS 9 headers and so f...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Only Me
Assignee: Alex Dupre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-01 18:16 UTC by Mark Millard
Modified: 2017-10-04 10:27 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ale)

Attachments
A pc_config.h patch to avoid powerpc misclassification (351 bytes, patch)
2017-10-01 18:20 UTC, Mark Millard 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Millard 2017-10-01 18:16:23 UTC 
[I tried to build math/gnuplot and it was
indirectly blocked by print/pdflib failing
to build for "missing" include files.]

The following avoids print/pdflib classifying the
context as an old MAC context (pre-MACOSX) when
building for powerpc64 (for example):

# more /usr/ports/print/pdflib/files/patch-libs_pdcore_pc__config.h
--- libs/pdcore/pc_config.h.orig        2012-06-06 11:58:58 UTC
+++ libs/pdcore/pc_config.h
@@ -179,9 +179,11 @@
 
 /* try to identify Mac OS 9 compilers */
 
+#if 0
 #if (defined macintosh || defined __POWERPC__ || defined __CFM68K__) && \
        !defined MAC && !defined MACOSX && !defined __BEOS__
 #define MAC
+#endif
 #endif
 
 /*
Comment 1 Mark Millard 2017-10-01 18:20:01 UTC 
Created attachment 186835 [details]
A pc_config.h patch to avoid powerpc misclassification


Avoid __POWERPC__ leading to needing old
MacOS 9 (pre-MacOSX) headers.
Comment 2 Mark Millard 2017-10-01 19:02:22 UTC 
I should have mentioned that my powerpc64
context is based on system clang 5, no
gcc 4.2.1 involved.

I do not expect that makes any difference
in the misclassification.

But my testing context is not normal for
powerpc64: important to know if anything
odd did show up in observed behavior.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-10-04 07:34:52 UTC 
A commit references this bug:

Author: ale
Date: Wed Oct  4 07:34:04 UTC 2017
New revision: 451181
URL: https://svnweb.freebsd.org/changeset/ports/451181

Log:
  Fix build on powerpc and strip binaries.

  PR:		222722
  Submitted by:	Mark Millard <markmi@dsl-only.net>

Changes:
  head/print/pdflib/Makefile
  head/print/pdflib/files/patch-libs_pdcore_pc__config.h
Comment 4 Mark Millard 2017-10-04 07:54:02 UTC 
(In reply to commit-hook from comment #3)

The commit comment makes no reference to
removing the following from the Makefile,
not mentioning why at all:

.if ${ARCH} == "amd64" || ${ARCH} == "sparc64"	 
CONFIGURE_ARGS+=--enable-64bit	 
.endif	 


(And why that older Makefile code omitted
powerpc64 I do not know.)
Comment 5 Alex Dupre freebsd_committer freebsd_triage 2017-10-04 10:27:12 UTC 
That flag doesn't do anything, it's a NOP on FreeBSD.