Created attachment 186908 [details] mgba.patch I'm surprised it wasn't already in ports, since the author officially supports FreeBSD…
+.include <bsd.port.options.mk> + +.if ${PORT_OPTIONS:MDEBUGGERS} +USES+= libedit +.endif + +.if ${PORT_OPTIONS:MQT} +USE_QT5= qmake_build buildtools_build core gui widgets network opengl multimedia +USES+= desktop-file-utils +INSTALLS_ICONS= yes +.endif Hmm, all of these variables are settable via options helpers. I don't understand why you stopped using them here. +LDFLAGS+= -L/usr/local/lib # sqlite3 Using /usr/local directly like this is not correct (LOCALBASE can be set to other values by users). Use ${LOCALBASE} instead or better yet replace the whole thing by adding localbase:ldflags to USES +FFMPEG_DESC= FFmpeg video recording support +MAGICK_DESC= ImageMagick GIF recording support +QT_DESC= Qt frontend Please move all custom descriptions to after the OPTIONS_* section followed by a section for the options helpers. Maybe rename QT->QT5. FFMPEG, MAGICK, QT5 already have descriptions in bsd.options.desc.mk. Do you need custom descriptions? https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-order-options
(In reply to Tobias Kortkamp from comment #1) I think the pkg-descr is a little short. Can you extend it just a little bit?
Created attachment 186925 [details] mgba.patch v2 (In reply to Tobias Kortkamp from comment #1) Because I can't remember which helpers exist and can't read documentation, apparently :D Fixed. About descriptions — "ImageMagick image processing library support" doesn't mean much in the context of an emulator. "Qt 5 toolkit support" is also a library-oriented description. "FFmpeg support (WMA, AIFF, AC3, APE...)" is even worse, these are music formats when mGBA uses ffmpeg to record video.
Committed with some minor changes. Thanks!
A commit references this bug: Author: tobik Date: Thu Oct 5 16:35:18 UTC 2017 New revision: 451322 URL: https://svnweb.freebsd.org/changeset/ports/451322 Log: New port: emulators/mgba A modern open source Game Boy Advance emulator, with support for Game Boy and Game Boy Color games as well. The project started in April 2013 with the goal of being fast enough to run on lower end hardware than other emulators support, without sacrificing accuracy or portability. Other goals include accurate enough emulation to provide a development environment for homebrew software, a good workflow for tool-assist runners, and a modern feature set for emulators that older emulators may not support. WWW: https://mgba.io PR: 222779 Submitted by: Greg V <greg@unrelenting.technology> Changes: head/emulators/Makefile head/emulators/mgba/ head/emulators/mgba/Makefile head/emulators/mgba/distinfo head/emulators/mgba/pkg-descr head/emulators/mgba/pkg-plist