Bug 222886 - [PATCH] update www/minio to RELEASE.2017-09-29T19-16-56Z
Summary: [PATCH] update www/minio to RELEASE.2017-09-29T19-16-56Z
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-10-10 00:07 UTC by John Hixson
Modified: 2017-10-10 18:06 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (swills)

Attachments
Minio port diff (5.32 KB, patch)
2017-10-10 00:07 UTC, John Hixson 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hixson freebsd_committer freebsd_triage 2017-10-10 00:07:29 UTC 
Created attachment 187034 [details]
Minio port diff
Comment 1 Steve Wills freebsd_committer freebsd_triage 2017-10-10 17:16:20 UTC 
(In reply to jhixson from comment #0)
Why was the comment on meaning of minio_logfile removed from minio.in in this patch? And why the other whitespace changes to minio.in?
Comment 2 Steve Wills freebsd_committer freebsd_triage 2017-10-10 17:46:57 UTC 
(In reply to jhixson from comment #0)
And why is there a patch to the Makefile added when we don't call make during the build? Also, the patch to cmd/build-constants.go isn't needed, nor is the additional distfile.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-10-10 18:04:18 UTC 
A commit references this bug:

Author: swills
Date: Tue Oct 10 18:03:40 UTC 2017
New revision: 451712
URL: https://svnweb.freebsd.org/changeset/ports/451712

Log:
  www/minio: update to RELEASE.2017-09-29T19-16-56Z

  While here, disable CGO since it's not needed and this gives a static binary
  like upstream ships. And remove CC=clang check since we don't use CC any more.
  Also, shorten the install command for readability.

  PR:		222886
  Submitted by:	jhixson@gmail.com (inspired by)

Changes:
  head/www/minio/Makefile
  head/www/minio/distinfo
Comment 4 Steve Wills freebsd_committer freebsd_triage 2017-10-10 18:06:03 UTC 
Committed, thanks!