Bug 223021 - databases/sqlcipher: Update to 3.4.1
Summary: databases/sqlcipher: Update to 3.4.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks: 222949
  Show dependency treegraph
 
Reported: 2017-10-15 07:14 UTC by Yuri Victorovich
Modified: 2017-10-21 09:22 UTC (History)
2 users (show)

See Also:
jharris: maintainer-feedback+


Attachments
patch (1.25 KB, patch)
2017-10-15 07:14 UTC, Yuri Victorovich
no flags Details | Diff
patch (1.51 KB, patch)
2017-10-15 18:36 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-10-15 07:14:56 UTC
Created attachment 187187 [details]
patch

QAs:
* passes poudriere 11.1
* portlint
* works fine
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-15 10:13:27 UTC
On 12-current I get:
===========================================================================
====> Running Q/A tests (stage-qa)
Error: Bad linking on [libedit.so.7] for /usr/local/bin/sqlcipher please add USES=libedit
*** Error code 1


Could you investigate why it fails -- as you already have that?
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-10-15 16:31:17 UTC
(In reply to Tobias C. Berner from comment #1)

The immediate reason of this problem in databases/sqlcipher is that the executable links with the base /lib/libedit.so.7 on 12, and with the port's /usr/local/lib/libedit.so.0 on 11.

IMO, in such situations port version should always take precedence, and linking to the base version should be made an error. My suggested stage-qa check bug#221134 aims at detecting such problems in cases of other libraries.

I will see if I can find a solution of this for databases/sqlcipher
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-10-15 18:36:55 UTC
Created attachment 187200 [details]
patch

Fixed stage-qa warning about libedit on 12.
It was caused because on 12 SSL_DEFAULT=base, and on 11 SSL_DEFAULT=openssl, library path set by USES=ssl was causing build to choose base libedit.
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-18 20:22:12 UTC
Great, I'll add it as soon as jharris gives the ok.
Comment 5 jharris 2017-10-19 17:06:14 UTC
Approved w/unfortunately limited testing.  Thanks!
Comment 6 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-19 17:31:05 UTC
Yuri, how about using USES=localbase?
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2017-10-20 01:42:28 UTC
Tobias,

USES=localbase would append values, and they should be prepended.


Yuri
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-10-21 09:21:22 UTC
A commit references this bug:

Author: tcberner
Date: Sat Oct 21 09:20:22 UTC 2017
New revision: 452580
URL: https://svnweb.freebsd.org/changeset/ports/452580

Log:
  Update databases/sqlcipher to 3.4.1

  * Adds LOCALBASE paths to the c- and linker-flags to fix wrongful linking against
    base's libedit.

  * While here, switch to DISTVERSION.

  PR:		223021
  Submitted by:	Yuri Victorovich <yuri@rawbw.com>
  Approved by:	jharris@widomaker.com (maintainer)

Changes:
  head/databases/sqlcipher/Makefile
  head/databases/sqlcipher/distinfo
Comment 9 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-21 09:22:46 UTC
Committed. Thanks.