Created attachment 187187 [details] patch QAs: * passes poudriere 11.1 * portlint * works fine
On 12-current I get: =========================================================================== ====> Running Q/A tests (stage-qa) Error: Bad linking on [libedit.so.7] for /usr/local/bin/sqlcipher please add USES=libedit *** Error code 1 Could you investigate why it fails -- as you already have that?
(In reply to Tobias C. Berner from comment #1) The immediate reason of this problem in databases/sqlcipher is that the executable links with the base /lib/libedit.so.7 on 12, and with the port's /usr/local/lib/libedit.so.0 on 11. IMO, in such situations port version should always take precedence, and linking to the base version should be made an error. My suggested stage-qa check bug#221134 aims at detecting such problems in cases of other libraries. I will see if I can find a solution of this for databases/sqlcipher
Created attachment 187200 [details] patch Fixed stage-qa warning about libedit on 12. It was caused because on 12 SSL_DEFAULT=base, and on 11 SSL_DEFAULT=openssl, library path set by USES=ssl was causing build to choose base libedit.
Great, I'll add it as soon as jharris gives the ok.
Approved w/unfortunately limited testing. Thanks!
Yuri, how about using USES=localbase?
Tobias, USES=localbase would append values, and they should be prepended. Yuri
A commit references this bug: Author: tcberner Date: Sat Oct 21 09:20:22 UTC 2017 New revision: 452580 URL: https://svnweb.freebsd.org/changeset/ports/452580 Log: Update databases/sqlcipher to 3.4.1 * Adds LOCALBASE paths to the c- and linker-flags to fix wrongful linking against base's libedit. * While here, switch to DISTVERSION. PR: 223021 Submitted by: Yuri Victorovich <yuri@rawbw.com> Approved by: jharris@widomaker.com (maintainer) Changes: head/databases/sqlcipher/Makefile head/databases/sqlcipher/distinfo
Committed. Thanks.