Bug 223079 - deskutils/xfce4-notifyd: Update to 0.4.0
Summary: deskutils/xfce4-notifyd: Update to 0.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-18 06:26 UTC by Olivier Duchateau
Modified: 2017-10-19 07:13 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
Patch to update deskutils/xfce4-notifyd (2.89 KB, patch)
2017-10-18 06:26 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2017-10-18 06:26:19 UTC 
Created attachment 187261 [details]
Patch to update deskutils/xfce4-notifyd

- Update to 0.4.0
- Adjust dependencies (DBus is not anymore used, xfce4-notifyd uses gdbus-codegen from GLib)
- Sort USES
Comment 1 Olivier Duchateau 2017-10-18 08:44:03 UTC 
I just submitted a patch [1] which fixes some assignment warnings (during build stage). It's not yet reviewed.

[1] https://bugzilla.xfce.org/show_bug.cgi?id=13931
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2017-10-18 14:27:15 UTC 
Looks good to me. I've tested it on 11.1 amd64. Would you like me to commit the update or wait till your external patch has received further review?
Comment 3 Olivier Duchateau 2017-10-18 18:49:42 UTC 
(In reply to Emanuel Haupt from comment #2)

You can commit the update, my external patch fixes only warnings (and there are still), it's not blocking.
Comment 4 Emanuel Haupt freebsd_committer freebsd_triage 2017-10-18 19:35:41 UTC 
It seems like devel/dbus-glib and devel/dbus are still needed.


# make stage-qa
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/xfce4-notifyd-config is linked to /usr/local/lib/libdbus-glib-1.so.2 from devel/dbus-glib but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libdbus-glib-1.so:devel/dbus-glib
Error: /usr/local/bin/xfce4-notifyd-config is linked to /usr/local/lib/libdbus-1.so.3 from devel/dbus but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libdbus-1.so:devel/dbus
Comment 5 Olivier Duchateau 2017-10-18 20:04:13 UTC 
(In reply to Emanuel Haupt from comment #4)

You are right. I saw only gdbus-codegen and not dbus-binding-tool.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-10-19 07:13:14 UTC 
A commit references this bug:

Author: ehaupt
Date: Thu Oct 19 07:13:05 UTC 2017
New revision: 452398
URL: https://svnweb.freebsd.org/changeset/ports/452398

Log:
  Update to 0.4.0

  PR:		223079
  Submitted by:	duchateau.olivier@gmail.com

Changes:
  head/deskutils/xfce4-notifyd/Makefile
  head/deskutils/xfce4-notifyd/distinfo
  head/deskutils/xfce4-notifyd/pkg-plist
Comment 7 Emanuel Haupt freebsd_committer freebsd_triage 2017-10-19 07:13:58 UTC 
Committed, thanks!