Bug 223122 - sysutils/nut -- error building 2.7.4_5
Summary: sysutils/nut -- error building 2.7.4_5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-20 05:19 UTC by elij
Modified: 2018-01-13 07:10 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (cy)

Attachments
poudriere failure log (103.64 KB, text/plain)
2017-10-20 05:19 UTC, elij 		no flags Details
nut libusb patch. (1.77 KB, patch)
2017-10-20 07:47 UTC, Cy Schubert 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description elij 2017-10-20 05:19:56 UTC 
Created attachment 187318 [details]
poudriere failure log

Build errors. "error: use of undeclared identifier"
See attached poudriere output error log.
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2017-10-20 07:44:53 UTC 
It appears to affect stable and i386 current: I can reproduce this under current on i386 requiring libusb.h in two files. I will upload shortly after some additional testing... which just completed.
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2017-10-20 07:47:58 UTC 
Created attachment 187324 [details]
nut libusb patch.

Try this patch. It should fix stable and current on i386. (Current on amd64 works without it.)
Comment 3 elij 2017-10-20 08:12:22 UTC 
I'm running FreeBSD-11.1-RELEASE-p1 on amd64, which wasn't actually working.
I'll give the patch a try though.
Comment 4 elij 2017-10-20 08:18:14 UTC 
Confirmed. Patch fixes the build for me on amd64 / FreeBSD-11.1-RELEASE-p1.
Comment 5 Dean E. Weimer 2017-10-20 12:04:39 UTC 
The patch Attachment #187324 [details], fixed my system 11.1-p2 amd64 as well. Also discovered prior to patch that if I removed the Serial option the port would build. Builds fine after patch with serial option checked.
Comment 6 Lev A. Serebryakov freebsd_committer freebsd_triage 2017-10-20 12:07:11 UTC 
Oh, sorry, I had SERIAL turned off too when tested patch which leads to this problem. My mistake.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-10-20 14:52:23 UTC 
A commit references this bug:

Author: cy
Date: Fri Oct 20 14:51:35 UTC 2017
New revision: 452531
URL: https://svnweb.freebsd.org/changeset/ports/452531

Log:
  Fix build with SERIAL option.

  PR:		223122

Changes:
  head/sysutils/nut/Makefile
  head/sysutils/nut/files/patch-drivers_libshut.c
  head/sysutils/nut/files/patch-drivers_usbhid-ups.c
Comment 8 Walter Schwarzenfeld 2018-01-13 07:06:55 UTC 
Forgotten to close?