x11/kdelibs4 has a patch, patch-solid_solid_backends_hal_halstorageaccess.cpp, that adds 'large' option to msdosfs (aka vfat) mount command if that option is reported as supported by hal. The option was removed in head in commit base r319735 after completion of the ino64 project. hal still advertises 'large' as a valid option for all version of FreeBSD, see bug #221709. Conditionally removing that option in either hal or kde would work. While I am here I would like to point out that patch-solid_solid_backends_hal_halstorageaccess.cpp contains a bug. It adds this line: if ( halOptions.contains("-L=") && (cType = getenv("LC_ALL")) || (cType = getenv("LC_CTYPE")) || (cType = getenv("LANG")) ) it can be written in a compact form as if ( A && B || C || D ) which equivalent to if ( (A && B) || C || D ) but it really should be if ( A && (B || C || D) )
ping!
Created attachment 190753 [details] Proposed patch Does the attached patch work for you?
A commit references this bug: Author: adridg Date: Mon Apr 9 08:57:19 UTC 2018 New revision: 466840 URL: https://svnweb.freebsd.org/changeset/ports/466840 Log: 'large' is no longer a valid msdosfs mount option in head after r319735. Removes the -o large passed to mount, when kdelibs-kde4 is built on a recent-ish 12-CURRENT system. At the same time, fix a logic error regarding the handling of the -L flag reported by HAL. PR: 223125 Submitted by: rakuco Reported by: avg Approved by: tcberner (mentor, implicit) Changes: head/x11/kdelibs-kde4/Makefile head/x11/kdelibs-kde4/files/patch-solid_solid_backends_hal_halstorageaccess.cpp
I've committed the patch from rakuco@, on the grounds that fixing the logical error is important anyway, and treusting that the version check for deciding to use "-o large" makes sense.