Bug 223187 - www/davical 1.1.5 incompatible with Postgres 10.0
Summary: www/davical 1.1.5 incompatible with Postgres 10.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-23 13:39 UTC by karl
Modified: 2017-10-26 17:40 UTC (History)
2 users (show)

See Also:
linimon: maintainer-feedback? (rigoletto)

Attachments
patch: temporarily restrict davical to pgsql:9.6- (506 bytes, patch)
2017-10-24 00:12 UTC, Alexandre C. Guimarães 		rigoletto: maintainer-approval+
Details | Diff
patch: fix PostgreSQL :10 support. (77.56 KB, patch)
2017-10-24 05:44 UTC, Alexandre C. Guimarães 		rigoletto: maintainer-approval+
Details | Diff
patch: fix PostgreSQL 10 support. (77.20 KB, patch)
2017-10-24 05:47 UTC, Alexandre C. Guimarães 		rigoletto: maintainer-approval+
Details | Diff
patch: fix PostgreSQL 10 support. (3.57 KB, patch)
2017-10-24 19:25 UTC, Alexandre C. Guimarães 		rigoletto: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description karl 2017-10-23 13:39:01 UTC 
Postgres 10.0 made a change which forbids the return of a set in functions containing a CASE statement.  Davical has this structure in several function definitions, and if Postgres is upgraded to 10.0 this fatally breaks Davical 1.1.5.

The Davical folks have fixed this by rewriting their function prototypes, and the fix is backward-compatible with earlier Postgres versions.

The fix can be found here: https://gitlab.com/davical-project/davical/commit/39001794a3121c33c8cba50398b653a94328be40

Since Postgres 10 is now out of beta and in general release anyone with both packages installed who tries to roll Postgres forward is in for a nasty surprise until the function prototypes are fixed for the Davical port.
Comment 1 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-10-24 00:12:07 UTC 
Created attachment 187408 [details]
patch: temporarily restrict davical to pgsql:9.6-

I am not adding the upstream patch right now; first because I do not have means to test it before weekend, and second because I do want to find out if it is expected to have more issues related with PostgreSQL 10 yet.

Thank you for reporting.
Comment 2 karl 2017-10-24 00:18:33 UTC 
(In reply to Le Baron d'Merde from comment #1)

The patch is fine I'm running it in production against both 10.0 and 9.x on Stable-11
Comment 3 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-10-24 05:44:13 UTC 
Created attachment 187413 [details]
patch: fix PostgreSQL :10 support.

The attached patch does:

* add upstream patch to fix www/davical against PostgreSQL 10
* bump PORTREVISION
Comment 4 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-10-24 05:47:15 UTC 
Created attachment 187414 [details]
patch: fix PostgreSQL 10 support.

The attached patch does:

* add upstream patch to fix www/davical against PostgreSQL 10
* bump PORTREVISION
Comment 5 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-10-24 19:25:09 UTC 
Created attachment 187447 [details]
patch: fix PostgreSQL 10 support.

The attached patch does:

* add upstream patch to fix www/davical against PostgreSQL 10
* bump PORTREVISION

Small rework of the previous one.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-10-26 17:39:59 UTC 
A commit references this bug:

Author: tcberner
Date: Thu Oct 26 17:39:50 UTC 2017
New revision: 452931
URL: https://svnweb.freebsd.org/changeset/ports/452931

Log:
  Fix www/davical to be comptible with Postgres 10.0

  PR:		223187
  Submitted by:	Le Baron d'Merde <lbdm@privacychain.ch> (maintainer)
  Reported by:	karl@denninger.net

Changes:
  head/www/davical/Makefile
  head/www/davical/files/patch-git_39001794
Comment 7 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-26 17:40:35 UTC 
Committed. Thanks.