1. It looks state file in wrong place /var/lib/logrotate.status instead of /var/run/logrotate.status 2. compressing log with: /bin/gzip instead of /usr/bin/gzip
Totally my mistake, a file has been left out from the previous patch.
Created attachment 187473 [details] fixes configure.ac to select default paths for FreeBSD Default paths definition went to configure.ac, which has been left out from the initial 3.13.0 patch for some reason.
Patch has error ++ UNCOMPRESS_COMMAND="/usr/bin/ginzip" must be gunzip
Created attachment 187667 [details] this patch fixes configure.ac to select default paths for FreeBSD Feeble me, typo.
Bump
Created attachment 188777 [details] updated patch I think this patch may be better for the port. Please take a look. Your patch is good and would be great to send upstream, but since there are configure args for these settings it is better to use those. While here, I've also cleaned up the port a bit by making sure we don't silence install things, which we normally don't do, simplified a bit by using USES=localbase instead of appending those settings to CONFIGURE_ARGS and sorted USES. If this looks OK to you, please mark the patch as maintainer approved and set the previous change as obsolete.
So what's up with Attachment #187667 [details]? We now have an inoperable logrotate ...
Comment on attachment 188777 [details] updated patch This bugzilla looks like our enterprise applications. I hope it didn't cost millions. Is there a way to persist maintainer-approval flags?
(In reply to js from comment #8) Hereby I, as the ports maintainer of logrotate, I approve "updated patch", with the ID of 188777, to be applied to logrotate port. I don't know why my setting the flag haven't been saved. As the ticket is open for almost two months now, and the fix being pretty much straightforward, I believe we should not wait until bugzilla setup is "fixed".
(In reply to js from comment #8) The criteria for our new PR system were: - it had to be better than GNATS. - it had to be free and open-source. - it had to have some degree of community support (outside of FreeBSD). - it had to be better than the other alternatives that met the above. I wasn't involved in the Bugzilla installation, but I was involved in the previous round of discussions on how to replace it. The first one, everyone agreed on*. The second one and third ones, most people agreed on. The fourth one, everyone had their own opinions and the one was picked that the least number of people found objectionable. My own opinion after years of working on various PR systems is that they are all terrible. I also read the big caution "Do not write your own!" on one web page as being a sad story from experience. (At one time I did try to customize a non-open-source alternative to our needs: the effort failed.) So, while I understand that Bugzilla is frustrating to use, I honestly believe we made the best decision possible at the time, given the resources we had. mcl * a low bar, to be sure. (In reply to js from comment #9) (In reply to js from comment #9)
(In reply to js from comment #9) We have far more PRs than we have committer resources. All we can ask is that you please be patient.
A commit references this bug: Author: swills Date: Wed Dec 20 02:31:41 UTC 2017 New revision: 456774 URL: https://svnweb.freebsd.org/changeset/ports/456774 Log: sysutils/logrotate: fix paths after upate to 3.13.0 While here add USES=localbase and unmute post-install tasks PR: 223227 Submitted by: a.ulasov@gmail.com (inspired by) Approved by: js@iksz.hu (maintainer) Changes: head/sysutils/logrotate/Makefile
Committed, thanks!