Bug 223257 - www/firefox Debugger not working in 56.0.1
Summary: www/firefox Debugger not working in 56.0.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-26 06:47 UTC by Rodrigo Osorio
Modified: 2017-10-26 17:14 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gecko)

Attachments
counsole debug output (9.71 KB, text/plain)
2017-10-26 07:01 UTC, Rodrigo Osorio 		no flags Details
screenshot (128.04 KB, image/png)
2017-10-26 09:47 UTC, Rodrigo Osorio 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rodrigo Osorio freebsd_committer freebsd_triage 2017-10-26 06:47:59 UTC 
The Firefox JS debbuger is not working anymore in at least v56.0.1, it only displays an empty window. This feature works fine in firefox-esr (currently firefox-esr-52.4.1_1,1)

Tested with FreeBSD 11.1-RELEASE-p1 and FreeBSD 12.0-CURRENT #0 r323178
Comment 1 Rodrigo Osorio freebsd_committer freebsd_triage 2017-10-26 07:01:01 UTC 
Created attachment 187489 [details]
counsole debug output
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-10-26 07:49:14 UTC 
A commit references this bug:

Author: jbeich
Date: Thu Oct 26 07:48:15 UTC 2017
New revision: 452907
URL: https://svnweb.freebsd.org/changeset/ports/452907

Log:
  www/firefox: unbreak JS debugger

  console.error:
    Message: TypeError: KEYS[os] is undefined
    Stack:
      getKeyForOS@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29496:4
  getKey@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29492:11
  formatKey@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29500:14
  renderPauseButton@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29575:94
  render@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29603:58
  [...]

  PR:		223257
  Reported by:	rodrigo
  MFH:		2017Q4

Changes:
  head/www/firefox/Makefile
  head/www/firefox/files/patch-bug1401573
Comment 3 Jan Beich freebsd_committer freebsd_triage 2017-10-26 07:50:48 UTC 
Can you try again?
Comment 4 Rodrigo Osorio freebsd_committer freebsd_triage 2017-10-26 09:47:00 UTC 
Created attachment 187495 [details]
screenshot
Comment 5 Jan Beich freebsd_committer freebsd_triage 2017-10-26 10:02:53 UTC 
Comment on attachment 187495 [details]
screenshot

Is this for firefox-56.0.2_3,1 ? I can't reproduce. Please, show JS backtrace.

Binary packages are built every 2 days at 01:00 UTC. comment 2 didn't land in time, so expect the package no sooner than 2017-10-28. -RELEASE users are on /quarterly by default, so I also need to MFH to 2017Q4.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-10-26 17:14:38 UTC 
A commit references this bug:

Author: jbeich
Date: Thu Oct 26 17:13:58 UTC 2017
New revision: 452930
URL: https://svnweb.freebsd.org/changeset/ports/452930

Log:
  MFH: r452907

  www/firefox: unbreak JS debugger

  console.error:
    Message: TypeError: KEYS[os] is undefined
    Stack:
      getKeyForOS@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29496:4
  getKey@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29492:11
  formatKey@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29500:14
  renderPauseButton@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29575:94
  render@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/debugger/new/debugger.js:29603:58
  [...]

  PR:		223257
  Reported by:	rodrigo
  Approved by:	ports-secteam (swills)

Changes:
_U  branches/2017Q4/
  branches/2017Q4/www/firefox/Makefile
  branches/2017Q4/www/firefox/files/patch-bug1401573