Bug 223277 - math/octave: fails to build on armv6
Summary: math/octave: fails to build on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Many People
Assignee: Stephen Montgomery-Smith
URL: http://beefy8.nyi.freebsd.org/data/he...
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-27 12:48 UTC by Mikael Urankar
Modified: 2025-01-28 14:32 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (maho)

Attachments
patch (1.42 KB, patch)
2017-10-27 12:48 UTC, Mikael Urankar 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2017-10-27 12:48:38 UTC 
Created attachment 187518 [details]
patch

See [1] for build error
octave uses the deprecated FPU control interface (fpsetmask) that is
not available on ARM (and other arch, see r226607 for details).
Use fedisableexcept instead

[1] http://beefy8.nyi.freebsd.org/data/head-armv6-default/p452566_s324810/logs/errors/octave-4.0.3_8.log
Comment 1 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2018-03-08 03:53:34 UTC 
I had to slightly change the patch, because it was applied to Octave-4.2.1.  I have committed it - please tell me if it works for you, because I don't have access to an armv6.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-03-08 03:55:46 UTC 
A commit references this bug:

Author: stephen
Date: Thu Mar  8 03:55:17 UTC 2018
New revision: 463862
URL: https://svnweb.freebsd.org/changeset/ports/463862

Log:
  - Fix build on armv6.

  PR:		ports/223277
  Submitted by:	mikael.urankar@gmail.com

Changes:
  head/math/octave/files/patch-libinterp_corefcn_sysdep.cc
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2018-03-11 06:55:17 UTC 
Committed Thu Mar  8 03:55:17 UTC 2018.
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-01-28 14:29:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6db8884be4287fe981d15bda1414417cc0c6b181

commit 6db8884be4287fe981d15bda1414417cc0c6b181
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2025-01-22 19:07:01 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2025-01-28 14:27:37 +0000

    math/octave: fix build on armv7

    Restore a patch due to mikael@ that was mangled in a previous update.

    Fixes:          6473aac25b6dc63be299faa4fc1ed9cde77f1957
    Approved by:    portmgr (build fix blanket)
    MFH:            2025Q1
    PR:             223277

 math/octave/files/patch-libinterp_corefcn_sysdep.cc | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-01-28 14:32:09 UTC 
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7bf8b65e5079f7629f08a3054cadfed32762b8e5

commit 7bf8b65e5079f7629f08a3054cadfed32762b8e5
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2025-01-22 19:07:01 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2025-01-28 14:30:54 +0000

    math/octave: fix build on armv7

    Restore a patch due to mikael@ that was mangled in a previous update.

    Fixes:          6473aac25b6dc63be299faa4fc1ed9cde77f1957
    Approved by:    portmgr (build fix blanket)
    MFH:            2025Q1
    PR:             223277

    (cherry picked from commit 6db8884be4287fe981d15bda1414417cc0c6b181)

 math/octave/files/patch-libinterp_corefcn_sysdep.cc | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)