Bug 223291 - sysutils/p5-File-Stat-Bits: Fix for dev_t size change
Summary: sysutils/p5-File-Stat-Bits: Fix for dev_t size change
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jim Pirzyk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-28 19:04 UTC by Jim Pirzyk
Modified: 2019-01-08 12:58 UTC (History)
2 users (show)

See Also:
koobs: merge-quarterly?

Attachments
Patch to handle change in dev_t size (2.06 KB, patch)
2017-10-28 19:04 UTC, Jim Pirzyk 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Pirzyk freebsd_committer freebsd_triage 2017-10-28 19:04:02 UTC 
Created attachment 187545 [details]
Patch to handle change in dev_t size

This is a fix for the dev_t size change as eluded to in 221784.  The only change to the gen-stat.c patch in that PR is the change of the printf line from this:

printf("sub %-12s () { 0%06llo }\n", name, value);

to this:

printf("sub %-12s () { 0%06llo }\n", name, (unsigned long long) value);

Otherwise we get warnings when building on < FreeBSD-12 systems.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-10-29 02:11:55 UTC 
Hi Jim,

So that your maintainer lines and bugzilla account emails match and so the auto-assigner can work correctly, could you please create a new issue under the Services::Bug Tracker component to request the merging of your freebsd and non-freebsd bugzilla accounts.

Please add this issues ID to that new issues "See Also" field
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2017-10-29 02:12:34 UTC 
Comment on attachment 187545 [details]
Patch to handle change in dev_t size

Set maintainer approval correctly.

Reporter is committer (and maintainer) but emails do not currently match (pending account merging)
Comment 3 Jim Pirzyk freebsd_committer freebsd_triage 2017-11-15 16:43:05 UTC 
What is needed for this to be moved along?
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-01-08 12:56:39 UTC 
A commit references this bug:

Author: swills
Date: Tue Jan  8 12:56:20 UTC 2019
New revision: 489677
URL: https://svnweb.freebsd.org/changeset/ports/489677

Log:
  sysutils/p5-File-Stat-Bits: Fix for dev_t size change

  Fixes armv6 and armv7 build

  PR:		223291
  PR:		221784
  Submitted by:	mikael.urankar@gmail.com
  Approved by:	maintainer timeout (pirzyk, >1 year)

Changes:
  head/sysutils/p5-File-Stat-Bits/Makefile
  head/sysutils/p5-File-Stat-Bits/files/
  head/sysutils/p5-File-Stat-Bits/files/patch-t_gen-stat.c
Comment 5 Steve Wills freebsd_committer freebsd_triage 2019-01-08 12:58:16 UTC 
Committed, thanks!