Bug 223301 - New port: multimedia/cava Console-based Audio Visualizer for Alsa, MPD and Pulseaudio
Summary: New port: multimedia/cava Console-based Audio Visualizer for Alsa, MPD and Pu...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-29 11:06 UTC by omar.polo
Modified: 2017-10-30 09:47 UTC (History)
3 users (show)

See Also:


Attachments
shar archive of the port (325 bytes, text/plain)
2017-10-29 11:06 UTC, omar.polo
no flags Details
The real shar archive (7.67 KB, text/plain)
2017-10-29 16:35 UTC, omar.polo
no flags Details
cava.diff (11.18 KB, patch)
2017-10-30 08:34 UTC, Tobias Kortkamp
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description omar.polo 2017-10-29 11:06:58 UTC
Created attachment 187556 [details]
shar archive of the port

Console-based Audio Visualizer for Alsa, MPD and Pulseaudio
Comment 1 omar.polo 2017-10-29 16:35:33 UTC
Created attachment 187561 [details]
The real shar archive

For some reason, the old shar was empty. Here's the real shar
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-29 21:39:05 UTC
Hi

this fails to build for me on current:

--- cava ---
/bin/sh ./libtool  --tag=CC    --mode=link cc -std=c99 -Wall -Wextra -Wno-unused-result -Wno-maybe-uninitialized -I/usr/local/include -v -O2 -pipe  -fstack-protector -fno-strict-aliasing  -L/usr/local/lib -Wl,-rpath /usr/local/lib -fstack-protector -o cava cava-cava.o -liniparser -lpthread  -lm  -lncursesw
libtool: link: cc -std=c99 -Wall -Wextra -Wno-unused-result -Wno-maybe-uninitialized -I/usr/local/include -v -O2 -pipe -fstack-protector -fno-strict-aliasing -Wl,-rpath /usr/local/lib -fstack-protector -o cava cava-cava.o  -L/usr/local/lib -liniparser -lpthread -lm -lncursesw
FreeBSD clang version 5.0.0 (tags/RELEASE_500/final 312559) (based on LLVM 5.0.0svn)
Target: x86_64-unknown-freebsd12.0
Thread model: posix
InstalledDir: /usr/bin
 "/usr/bin/ld" --eh-frame-hdr -dynamic-linker /libexec/ld-elf.so.1 --hash-style=both --enable-new-dtags -o cava /usr/lib/crt1.o /usr/lib/crti.o /usr/lib/crtbegin.o -L/usr/local/lib -L/usr/lib -rpath /usr/local/lib cava-cava.o -liniparser -lpthread -lm -lncursesw -lgcc --as-needed -lgcc_s --no-as-needed -lc -lgcc --as-needed -lgcc_s --no-as-needed /usr/lib/crtend.o /usr/lib/crtn.o
cava-cava.o: In function `cb':
cava.c:(.text+0x1911): undefined reference to `pa_context_disconnect'
cava.c:(.text+0x1919): undefined reference to `pa_context_unref'
cava.c:(.text+0x1927): undefined reference to `pa_mainloop_quit'
cava.c:(.text+0x193b): undefined reference to `pa_mainloop_free'
[...]


(also note that InstallDir: /usr/bin there...)

mfg Tobias
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2017-10-30 08:34:11 UTC
Created attachment 187579 [details]
cava.diff

Here is a version that builds fine in Poudriere on 10.3/i386,
current/amd64 and fixes a bunch of other issues.  Most of the custom
patches don't appear to be necessary when we add USES=localbase.  I've
also moved the port to the audio category.  We already have a bunch of
other audio visualizers in it.

I've contributed an sndio input to cava and I've included a backport
of it here.  I'm hoping this is ok.
Comment 4 omar.polo 2017-10-30 09:13:59 UTC
Hi,

I apologize but I don't know why the `distfile` isn't in the shar archive (in fact is present in the source of the shar, but it isn't extracted). I tried to build it on a clean current and, at least to me, it compiles. I've created a vm with current, scp-ed the source then installed the deps and builded. Do I mistaken something? Also, I checked twice that it doesn't install anything outside PREFIX as the porter's handbook suggest.

Tobias Kortkamp: thanks for the patch! It's awesome. I didn't know about USE=localbase
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-10-30 09:44:45 UTC
A commit references this bug:

Author: tobik
Date: Mon Oct 30 09:44:13 UTC 2017
New revision: 453161
URL: https://svnweb.freebsd.org/changeset/ports/453161

Log:
  New port: audio/cava

  C.A.V.A. is a bar spectrum audio visualizer for the terminal using
  ALSA, PulseAudio, sndio or fifo buffer for input.

  This program is not intended for scientific use.  It's written to look
  responsive and aesthetic when used to visualize music.

  WWW: https://karlstav.github.io/cava

  - Include a backport of an sndio input contributed by me

  PR:		223301
  Submitted by:	omar.polo@protonmail.com (based on)

Changes:
  head/audio/Makefile
  head/audio/cava/
  head/audio/cava/Makefile
  head/audio/cava/distinfo
  head/audio/cava/files/
  head/audio/cava/files/patch-config.c
  head/audio/cava/files/patch-sndio
  head/audio/cava/pkg-descr
  head/audio/cava/pkg-plist
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2017-10-30 09:47:43 UTC
(In reply to omar.polo from comment #4)
Committed. Thanks!