I'm trying to compile openssl-1.0.2m from ports on 10.3-RELEASE-p20. The following options are enabled: DOCS EC SHARED THREADS ASM SSE2 SCTP The following options are disabled: MAN3 PADLOCK RFC3779 EXPCIPHERS ZLIB RC5 MD2 SSL2 SSL3 Things go fine, until s23_clnt.c ---- cc -I../crypto -I.. -I../include -fPIC -DOPENSSL_PIC -DOPENSSL_THREADS -pthread -D_THREAD_SAFE -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -DL_ENDIAN -O3 -Wall -O2 -pipe -O2 -march=native -Werror -Qunused-arguments -fstack-protector -fno-strict-aliasing -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DRC4_ASM -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DAES_ASM -DVPAES_ASM -DBSAES_ASM -DWHIRLPOOL_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -c s23_clnt.c -o s23_clnt.o s23_clnt.c:762:29: error: implicit declaration of function 'SSLv3_client_method' is invalid in C99 [-Werror,-Wimplicit-function-declaration] s->method = SSLv3_client_method(); ^ s23_clnt.c:762:27: error: incompatible integer to pointer conversion assigning to 'const SSL_METHOD *' (aka 'const struct ssl_method_st *') from 'int' [-Werror,-Wint-conversion] s->method = SSLv3_client_method(); ^ ~~~~~~~~~~~~~~~~~~~~~ 2 errors generated. *** Error code 1 ---- SSL3 disabling seems to be broken. Enabling SSE3 causes the build to work.
Created attachment 187687 [details] patch Patch you can put in /usr/ports/security/openssl/files/.
(In reply to Tijl Coosemans from comment #1) Thanksl I've given this a go and it builds and installs without the SSL3 option.
A commit references this bug: Author: brnrd Date: Fri Nov 3 15:51:11 UTC 2017 New revision: 453409 URL: https://svnweb.freebsd.org/changeset/ports/453409 Log: security/openssl: Unbreak build with No-SSLv3 - Importing patch from upstream PR: 223388 Submitted by: tijl Reported by: Laurence Parry <greenreaper@hotmail.com> Changes: head/security/openssl/files/patch-ssl_s23__clnt.c
Thanks for reporting and patching. Upstream figured it out as well so I included their patch.
A commit references this bug: Author: brnrd Date: Thu Dec 7 19:59:11 UTC 2017 New revision: 455752 URL: https://svnweb.freebsd.org/changeset/ports/455752 Log: MFH: r453409 r455706 security/openssl: Unbreak build with No-SSLv3 - Importing patch from upstream PR: 223388 Submitted by: tijl Reported by: Laurence Parry <greenreaper@hotmail.com> security/openssl: Update to 1.0.2n - Remove patch now included upstream - Include post-release patch for clang build error Security: 3bb451fc-db64-11e7-ac58-b499baebfeaf Approved by: ports-secteam (feld) Changes: _U branches/2017Q4/ branches/2017Q4/security/openssl/Makefile branches/2017Q4/security/openssl/distinfo branches/2017Q4/security/openssl/files/patch-ssl_fatalerrtest.c