Bug 223478 - textproc/ripgrep: Restore shell completion options broken by previous SIMD options patch
Summary: textproc/ripgrep: Restore shell completion options broken by previous SIMD op...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-06 17:50 UTC by Petteri Valkonen
Modified: 2017-11-11 19:02 UTC (History)
1 user (show)

See Also:


Attachments
Fix for shell completion config options (1.79 KB, patch)
2017-11-06 17:50 UTC, Petteri Valkonen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Valkonen 2017-11-06 17:50:28 UTC
Created attachment 187802 [details]
Fix for shell completion config options

The shell completion config options for Bash, Fish and ZSH were broken by the previous patch, which exposed SIMD options. The attached patch fixes the regression introduced in PR 223314.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-11-11 19:02:09 UTC
(In reply to petteri.valkonen from comment #0)
Committed. Thanks!

I moved the options just before post-patch though since that's the position
they should be in according to [1].

If a committer broke your port, please feel free to either mention it in the
PR (even when it's closed) or if you create a new bug CC them.

[1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-11-11 19:02:35 UTC
A commit references this bug:

Author: tobik
Date: Sat Nov 11 19:01:56 UTC 2017
New revision: 453990
URL: https://svnweb.freebsd.org/changeset/ports/453990

Log:
  textproc/ripgrep: Restore BASH, FISH, ZSH options

  They were broken by r453382 which introduced new AVX, SIMD options
  which overwrote the old ones.

  PR:		223478, 223314
  Submitted by:	petteri.valkonen@iki.fi (maintainer)

Changes:
  head/textproc/ripgrep/Makefile