Bug 223593 - net-im/ricochet: Add missing dependency (qt5-quickcontrols)
Summary: net-im/ricochet: Add missing dependency (qt5-quickcontrols)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL: https://reviews.freebsd.org/D13027
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-11-10 14:18 UTC by Vinícius Zavam
Modified: 2017-11-12 19:20 UTC (History)
2 users (show)

See Also:
dbaio: maintainer-feedback? (yuri)


Attachments
[PATCH] net-im/ricochet: add missing dependency (qt5-quickcontrols), r453899 (1.49 KB, patch)
2017-11-10 14:18 UTC, Vinícius Zavam
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vinícius Zavam freebsd_committer freebsd_triage 2017-11-10 14:18:10 UTC
Created attachment 187906 [details]
[PATCH] net-im/ricochet: add missing dependency (qt5-quickcontrols), r453899

WITHOUT 'qt5-quickcontrols' as dependency:

    % ricochet 
    JIT is disabled for QML. Property bindings and animations will be very slow. Visit https://wiki.qt.io/V4 to learn about possible solutions for your platform.
    QQmlApplicationEngine failed to load component
    qrc:/ui/main.qml:2 module "QtQuick.Controls" is not installed

WITH 'qt5-quickcontrols' as dependency:

    % ricochet
    JIT is disabled for QML. Property bindings and animations will be very slow. Visit https://wiki.qt.io/V4 to learn about possible solutions for your platform.
    qrc:/ui/MainWindow.qml:89:17: QML Loader: Binding loop detected for property "active"
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2017-11-10 14:18:10 UTC
Maintainer informed via mail
Comment 2 Vinícius Zavam freebsd_committer freebsd_triage 2017-11-10 14:28:53 UTC
how to deal with Tor, if one already has security/tor-devel installed?
Comment 3 Vinícius Zavam freebsd_committer freebsd_triage 2017-11-11 17:16:21 UTC
(In reply to Vinícius Zavam from comment #2)

root@moose:~ # pkg update -f
Updating FreeBSD repository catalogue...
Fetching meta.txz: 100%    944 B   0.9kB/s    00:01
Fetching packagesite.txz: 100%    6 MiB 406.6kB/s    00:15
Processing entries: 100%
FreeBSD repository update completed. 26923 packages processed.
All repositories are up to date.

root@moose:~ # pkg install ricochet
Updating FreeBSD repository catalogue...
FreeBSD repository is up to date.
All repositories are up to date.
Updating database digests format: 100%
The following 8 package(s) will be affected (of 0 checked):

New packages to be INSTALLED:
        ricochet: 1.1.4_8
        qt5-quick: 5.7.1_1
        qt5-xmlpatterns: 5.7.1
        qt5-qml: 5.7.1_1
        qt5-testlib: 5.7.1
        qt5-sql: 5.7.1
        tor: 0.3.1.8
        qt5-multimedia: 5.7.1_2

Number of packages to be installed: 8

The process will require 38 MiB more space.
7 MiB to be downloaded.

Proceed with this action? [y/N]: N

root@moose:~ # tor --version
Tor version 0.3.3.0-alpha-dev (git-039a77636730633e).

root@moose:~ # pkg info -x ^tor
tor-devel-0.3.2.3.a
torsocks-2.2.0

root@moose:~ # uname -a
FreeBSD moose 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r325706: Sat Nov 11 09:51:36 UTC 2017     root@moose:/usr/obj/usr/src/amd64.amd64/sys/MOOSE  amd64

root@moose:~ # date
Sat Nov 11 17:10:29 UTC 2017
Comment 4 Danilo G. Baio freebsd_committer freebsd_triage 2017-11-11 21:42:02 UTC
maintainer is a committer
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-11 21:45:51 UTC
Does anybody understand why USE_QT5=quickcontrols is required, but 'make stage-qa' doesn't say this like it normally does?
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-12 19:19:53 UTC
Thanks for your report!
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-11-12 19:20:39 UTC
A commit references this bug:

Author: yuri
Date: Sun Nov 12 19:19:38 UTC 2017
New revision: 454075
URL: https://svnweb.freebsd.org/changeset/ports/454075

Log:
  net-im/ricochet: add missing dependency (qt5-quickcontrols) and other changes

  Other changes
  * Added the TOR option that will allow to disable the Tor dependency for people with alternative Tor installations
  * Fixed the SSL path

  PR:		223593
  Reported by:	Vin?cius Zavam <egypcio@googlemail.com>
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D13027

Changes:
  head/net-im/ricochet/Makefile