Bug 223810 - [NEW PORT] security/py-ssh-audit: SSH server auditing
Summary: [NEW PORT] security/py-ssh-audit: SSH server auditing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-23 06:44 UTC by Piotr Kubaj
Modified: 2017-11-24 21:32 UTC (History)
1 user (show)

See Also:

Attachments
patch (2.99 KB, patch)
2017-11-23 06:44 UTC, Piotr Kubaj 		no flags Details | Diff
patch (3.22 KB, patch)
2017-11-23 07:40 UTC, Yuri Victorovich 		no flags Details | Diff
patch (4.38 KB, patch)
2017-11-23 08:31 UTC, Yuri Victorovich 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2017-11-23 06:44:12 UTC 
This port connects to the given SSH server and inspects its key exchange algorithms, MAC, ciphers and key types. It also gives helpful info how to improve configuration of these.

Builds and runs fine.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2017-11-23 06:44:37 UTC 
Created attachment 188203 [details]
patch

SVN patch
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-23 07:40:46 UTC 
Created attachment 188206 [details]
patch

The updated patch.

Added:
* Dependency py-colorama
* USE_PYTHON=concurrent
* prefix py- to the directory
* WWW: in pkg-descr
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2017-11-23 08:06:29 UTC 
(In reply to Yuri Victorovich from comment #2)
Why did you add py-colorama dependency? The script runs fine without it.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-23 08:11:24 UTC 
(In reply to Piotr Kubaj from comment #3)

Because it tries to find it:
> try:  # pragma: nocover
>         from colorama import init as colorama_init
>         colorama_init()  # pragma: nocover
> except ImportError:  # pragma: nocover
>         pass

It is an optional dependency, but we should support such dependencies if it is easy.
Comment 5 Piotr Kubaj freebsd_committer freebsd_triage 2017-11-23 08:17:00 UTC 
(In reply to Yuri Victorovich from comment #4)
I've seen that and tested this script with and without colorama. Honestly, I don't see any difference.

Moreover, the changelog mentions that it appeared in 1.7.0 to please Windows users:
add colors support for Microsoft Windows via optional colorama dependency
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-23 08:26:22 UTC 
(In reply to Piotr Kubaj from comment #5)

If it's not needed it should be patched away, because otherwise behavior might be different when colorama is installed.

I will patch it out.
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-23 08:31:12 UTC 
Created attachment 188208 [details]
patch

Thanks for pointing it out!
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-24 21:32:13 UTC 
Committed. Thank you for your submission!
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-11-24 21:32:42 UTC 
A commit references this bug:

Author: yuri
Date: Fri Nov 24 21:32:05 UTC 2017
New revision: 454849
URL: https://svnweb.freebsd.org/changeset/ports/454849

Log:
  New port: security/py-ssh-audit: SSH server auditing

  PR:		223810
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D13207

Changes:
  head/security/Makefile
  head/security/py-ssh-audit/
  head/security/py-ssh-audit/Makefile
  head/security/py-ssh-audit/distinfo
  head/security/py-ssh-audit/files/
  head/security/py-ssh-audit/files/patch-ssh-audit.py
  head/security/py-ssh-audit/pkg-descr