Bug 224200 - [PATCH] graphics/wayland: Update to 1.14
Summary: [PATCH] graphics/wayland: Update to 1.14
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords: patch
Depends on: 224226
Blocks:
  Show dependency tree / graph
 
Reported: 2017-12-09 14:16 UTC by Johannes Lundberg
Modified: 2017-12-10 19:02 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)

Attachments
Patch to update graphics/wayland to 1.14 (891 bytes, patch)
2017-12-09 14:16 UTC, Johannes Lundberg 		no flags Details | Diff
Updated patch. (19.20 KB, patch)
2017-12-09 21:17 UTC, Johannes Lundberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Lundberg 2017-12-09 14:16:54 UTC 
Created attachment 188646 [details]
Patch to update graphics/wayland to 1.14

Update graphics/wayland to latest version.
Comment 1 Val Packett 2017-12-09 15:40:45 UTC 
I would also disable posix_fallocate because it's now turned off for ZFS:

https://github.com/myfreeweb/freebsd-ports-dank/commit/78d0a7ed44214dd43e4dadd536f894ecbe67accd

And drop the unused kqueue patch in favor of only using libepoll-shim:

https://github.com/myfreeweb/freebsd-ports-dank/commit/61a5ab9c3ba475139184f4ed71757642de24ed55
Comment 2 Jan Beich freebsd_committer freebsd_triage 2017-12-09 19:45:02 UTC 
(In reply to Greg V from comment #1)
> https://github.com/myfreeweb/freebsd-ports-dank/commit/78d0a7ed44214dd43e4dadd536f894ecbe67accd

Please, don't patch what can be turned off via port's Makefile. Try instead:

CONFIGURE_ENV=	ac_cv_func_posix_fallocate=no # EINVAL for many FS on 12.0
Comment 3 Niclas Zeising freebsd_committer freebsd_triage 2017-12-09 20:27:28 UTC 
If someone could update the patch with Greg's and Jan's suggestions that would be very helpful!  I'll try to get this in asap, but there's a few things in the pipeline before that.
Comment 4 Johannes Lundberg 2017-12-09 21:17:18 UTC 
Created attachment 188671 [details]
Updated patch.

Removed old kqueue code and disabled posix_fallocate in makefile.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-12-09 22:02:46 UTC 
A commit references this bug:

Author: zeising
Date: Sat Dec  9 22:02:31 UTC 2017
New revision: 455878
URL: https://svnweb.freebsd.org/changeset/ports/455878

Log:
  Update wayland to 1.14.0

  Disable posix_fallocate since ZFS does not support it.
  Use epoll-shim instead of kqueue directly, from myfreeweb on github.

  PR:		224200
  Submitted by:	Johannes Lundberg

Changes:
  head/graphics/wayland/Makefile
  head/graphics/wayland/distinfo
  head/graphics/wayland/files/patch-configure.ac
  head/graphics/wayland/files/patch-src_wayland-os.c
  head/graphics/wayland/files/patch-src_wayland-os.h
  head/graphics/wayland/files/patch-src_wayland-server.c
  head/graphics/wayland/files/patch-src_wayland-shm.c
  head/graphics/wayland/files/patch-tests_event-loop-test.c
  head/graphics/wayland/files/patch-tests_os-wrappers-test.c
  head/graphics/wayland/files/patch-tests_test-runner.c
Comment 6 Niclas Zeising freebsd_committer freebsd_triage 2017-12-09 22:06:07 UTC 
Committed.  Thanks for the submission!