Created attachment 188699 [details] Update patch Update to the latest version: 20171112. The new FLAVORS support gives an opportunity to better support the PSL version of REDUCE. PSL is faster and is a more classic version. PSL is only supported on amd64 and i386 so we had always favored the CSL version of REDUCE (written in C++).
Created attachment 190411 [details] Update to version 20180117
testbuild@work
Created attachment 190545 [details] Update to version 20180117 Follow the handbook examples and rework a bit the flavors so that csl is built by default.
The testbuild in poudriere says: FLAVORS contains flavors that are not all [a-z0-9_]: CSL PSL Is that changed in the new version ?
Created attachment 190548 [details] Update to version 20180117 pkg-plist update for the new version.
(In reply to Kurt Jaeger from comment #4) Yes, sorry (that was not well documented in the handbook). Be sure to get the very latest... the pkg-plist changes for the csl were not correctly detected due to the flavor issues in the previous version.
Fails to build under poudriere, see http://people.freebsd.org/~pi/logs/math__reduce-cur-1518453655.txt (or 111 or 10i instead of cur)
It looks like it's missing USE_XORG= x11 xproto xft
(In reply to Kurt Jaeger from comment #7) (From the log) ... /usr/ports/math/reduce/work-csl/Reduce-svn4372-src/csl/fox/src/FX88591Codec.cpp In file included from /wrkdirs/usr/ports/math/reduce/work-csl/Reduce-svn4372-src/csl/fox/src/FX88591Codec.cpp:1: /wrkdirs/usr/ports/math/reduce/work-csl/Reduce-svn4372-src/csl/fox/include/xincs.h:188:10: fatal error: 'X11/X.h' file not found #include <X11/X.h> ^~~~~~~~~ 1 error generated. _____ looks like a missing dependency. It builds fine on my local system ... find /usr/local/ -name "X.h" -print /usr/local/include/X11/X.h
Next testbuild is with USE_XORG= x11 xext xproto xft
Well, if you build on a box with ports installed, it's not sure that your port contains all the dependencies. That's why a valid testbuild is best tested via poudriere 8-}
(In reply to Kurt Jaeger from comment #11) I have just never got sufficient resources to consider setting up poudriere builds :(. Thanks for checking, your next build should work.
poudriere bulk -T -j cur math/reduce@all builds flavor csl, but not psl. Before I can proceed, I have to analyse this.
(In reply to Kurt Jaeger from comment #13) Hmm ... have a log? It was building fine here on amd64, I didn't re-spin i386 after the update but it hadn't changed.
You tested it using FLAVOR=psl make check-plist or how did you test both FLAVORs ?
(I ask because you said you did not test using poudriere, and I did use poudriere and if poudriere does not build a port, it does not write a logfile...)
(In reply to Kurt Jaeger from comment #15) I just had the other one by default and then switched "if"s. I know ... naive.
Created attachment 190739 [details] Fixed flavors I don't know why, but renaming the flavors did the trick.
(In reply to Pedro F. Giffuni from comment #18) I spoke too soon. Renaming the flavors fixes the dependencies and configure but it's still building the csl version instead of psl.
(In reply to Pedro F. Giffuni from comment #19) Actually.. the flavors are not working. I think I may just have to split ports for redcsl and redpsl. :(
Created attachment 190874 [details] Update, giving up on flavors The flavors approach has failed so just do a simple update and leave the psl stuff out. A new reduce-psl port will be submitted independently.
Testbuilds done, looks good to me. Approved.
A commit references this bug: Author: pfg Date: Fri Feb 23 15:11:36 UTC 2018 New revision: 462702 URL: https://svnweb.freebsd.org/changeset/ports/462702 Log: math/reduce: update to latest snapshot and cleanup. Make clear we are building the Codemist Standard Lisp (CSL) version. Remove parts of the PSL version that were previously not very well maintained as they are being moved out into a separate port. PR: 224234 Approved by: pi Changes: head/math/reduce/Makefile head/math/reduce/distinfo head/math/reduce/files/patch-csl_fox_configure.ac head/math/reduce/files/patch-fox-configure.ac head/math/reduce/files/redpsl.1 head/math/reduce/files/runpsl.sh head/math/reduce/pkg-descr head/math/reduce/pkg-plist
A commit references this bug: Author: pfg Date: Fri Feb 23 15:21:21 UTC 2018 New revision: 462703 URL: https://svnweb.freebsd.org/changeset/ports/462703 Log: math/reduce: update to latest snapshot and cleanup. Pet portint: no functional change. PR: 224234 Approved by: pi (implicit) Changes: head/math/reduce/Makefile
Done, with some further portlinting. Thanks! For the record, the reduce-csl port is available in PR 226098.