Bug 224464 - audio/faad installs incorrect include/neaacdec.h, which breaks multimedia/libquicktime
Summary: audio/faad installs incorrect include/neaacdec.h, which breaks multimedia/lib...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2017-12-19 16:58 UTC by Mikhail Teterin
Modified: 2017-12-25 11:23 UTC (History)
2 users (show)

See Also:


Attachments
Explicitly set FAAD2_VERSION, upgrade (1.11 KB, patch)
2017-12-19 18:25 UTC, Mikhail Teterin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer freebsd_triage 2017-12-19 16:58:46 UTC
The ${LOCALBASE}/include/neaacdec.h installed by audio/faad defines the FAAD2_VERSION as "unknown".

This breaks the FAAD2-option of multimedia/libquicktime, because the configure-script tries to parse the FAAD2_VERSION:

     if(sscanf(FAAD2_VERSION, "%d.%d", &faad_major, &faad_minor) < 2)
       return -1;

The above test fails and the configure declares faad to be unavailable. It then proceeds to build libquicktime without faad (instead erroring-out) and the port fails to install, because ${STAGEDIR}${PREFIX}/lib/libquicktime/lqt_faad2.so does not exist.
Comment 1 Mikhail Teterin freebsd_committer freebsd_triage 2017-12-19 18:25:44 UTC
Created attachment 188978 [details]
Explicitly set FAAD2_VERSION, upgrade

FWIW, I filed a ticket with the upstream: https://sourceforge.net/p/faac/bugs/236/

Meanwhile, this patch both brute-force fixes this problem and upgrades the port from the current 2.8.6 to 2.8.8 (the latest upstream release at this time).
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-12-25 10:38:17 UTC
A commit references this bug:

Author: riggs
Date: Mon Dec 25 10:37:51 UTC 2017
New revision: 457214
URL: https://svnweb.freebsd.org/changeset/ports/457214

Log:
  Update to upstream version 2.8.8; fix build with multimedia/libquicktime

  Details:
  - Update to upstream version 2.8.8
  - Use REINPLACE_CMD to set FAAD2_VERSION definition for consumers like
    multimedia/libquicktime.
    This is, however, no longer supported upstream, see
    https://sourceforge.net/p/faac/bugs/236/
    In future, consumers need to change their detection mechanism for faad2

  PR:		224464
  Submitted by:	mi

Changes:
  head/audio/faad/Makefile
  head/audio/faad/distinfo