Bug 224475 - [MAINTAINER] graphics/gimmage: fix, and update to c++11 (removes BROKEN)
Summary: [MAINTAINER] graphics/gimmage: fix, and update to c++11 (removes BROKEN)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2017-12-20 05:45 UTC by Chris Hutchinson
Modified: 2017-12-24 18:56 UTC (History)
0 users

See Also:
portmaster: maintainer-feedback+

Attachments
svn diff for graphics/gimmage (2.58 KB, patch)
2017-12-20 05:45 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
svn diff for graphics/gimmage v2 (obsoletes previous) (4.24 KB, patch)
2017-12-20 05:53 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
svn diff for graphics/gimmage v3 (obsoletes previous) (4.33 KB, patch)
2017-12-20 17:25 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2017-12-20 05:45:35 UTC 
Created attachment 188985 [details]
svn diff for graphics/gimmage

OK this port has been listed as BROKEN
The svn diff attached to this pr(1) corrects that
by bringing it closer to c++11

Tested on:
FreeBSD dev-box 12.0-CURRENT FreeBSD 12.0-CURRENT #0: Wed Dec 13 06:07:59 PST 2017 root@dev-box:/usr/obj/usr/src/amd64.amd64/sys/DEVBOX (r326065)

with the following results:

Script started on Tue Dec 19 21:03:24 2017
dev-box# make -DBATCH check-plist
   ...

install  -m 0644 'gimmage.desktop' '/usr/ports/graphics/gimmage/work/stage/usr/local/share/applications/gimmage.desktop'
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)

dev-box# make stage-qa
====> Running Q/A tests (stage-qa)

dev-box# make check-sanity
===>  License GPLv2+ accepted by the user

dev-box# portlint
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
WARN: /usr/ports/graphics/gimmage/files/patch-src__FileManager.cpp: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
WARN: /usr/ports/graphics/gimmage/files/patch-src__ImageEventBox.cpp: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
0 fatal errors and 3 warnings found.

dev-box# exit
Script done on Tue Dec 19 21:25:38 2017

Thanks!

--Chris
Comment 1 Chris Hutchinson 2017-12-20 05:53:18 UTC 
Created attachment 188986 [details]
svn diff for graphics/gimmage v2 (obsoletes previous)

Oops! forgot the additional patch added for
this PORTREVISION.
Comment 2 Chris Hutchinson 2017-12-20 17:25:42 UTC 
Created attachment 189000 [details]
svn diff for graphics/gimmage v3 (obsoletes previous)

This (final) snv diff simply pets portlint
(the NLS warning/suggestion)

That's it!

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-12-24 18:56:25 UTC 
A commit references this bug:

Author: swills
Date: Sun Dec 24 18:55:45 UTC 2017
New revision: 457192
URL: https://svnweb.freebsd.org/changeset/ports/457192

Log:
  graphics/gimmage: fix, and update to c++11

  PR:		224475
  Submitted by:	Chris Hutchinson <portmaster@bsdforge.com> (maintainer)

Changes:
  head/graphics/gimmage/Makefile
  head/graphics/gimmage/files/patch-src__FileManager.cpp
  head/graphics/gimmage/files/patch-src__ImageEventBox.cpp
Comment 4 Steve Wills freebsd_committer freebsd_triage 2017-12-24 18:56:55 UTC 
Committed, thanks!