Bug 224510 - net-mgmt/nagvis patch for php7
Summary: net-mgmt/nagvis patch for php7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-21 20:49 UTC by Palle Girgensohn
Modified: 2018-01-23 10:25 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (derfi)

Attachments
nagvis support for php7 (4.28 KB, patch)
2017-12-21 20:49 UTC, Palle Girgensohn 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Palle Girgensohn freebsd_committer freebsd_triage 2017-12-21 20:49:26 UTC 
Created attachment 189020 [details]
nagvis support for php7

PHP 7 gives these warnings:
Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; StringReader has a deprecated constructor in .../streams.php on line 48
...
Comment 1 Palle Girgensohn freebsd_committer freebsd_triage 2017-12-21 20:49:43 UTC 
OK to commit?
Comment 2 Palle Girgensohn freebsd_committer freebsd_triage 2018-01-23 10:25:43 UTC 
committed after maintainer timeout (1 mounth)
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-01-23 10:25:53 UTC 
A commit references this bug:

Author: girgen
Date: Tue Jan 23 10:25:03 UTC 2018
New revision: 459737
URL: https://svnweb.freebsd.org/changeset/ports/459737

Log:
  Fix runtime problems with some constructs deprecated by php7

  - functions cannot use the same parameter name multiple times, even if they are
    unused
  - constructors are now alwatys named __construct

  PR:	224510 (Maintainer timeout)

Changes:
  head/net-mgmt/nagvis/Makefile
  head/net-mgmt/nagvis/files/patch-share_server_core_classes_objects_NagVisService.php
  head/net-mgmt/nagvis/files/patch-share_server_core_ext_php_gettext.php