Bug 224616 - emulators/virtualbox-ose-additions does not detect PAE
Summary: emulators/virtualbox-ose-additions does not detect PAE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-27 14:29 UTC by Mikhail Teterin
Modified: 2024-06-28 19:28 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (vbox)

Attachments
Add PAE-option (1.63 KB, patch)
2018-02-16 20:34 UTC, Mikhail Teterin 		grahamperrin: maintainer-approval? (vbox)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer freebsd_triage 2017-12-27 14:29:30 UTC 
I could not get my PAE-using VBox guest to load vboxguest-module properly -- and, consequently, could not get X to work, etcaetera -- until I added -DPAE to the CFLAGS and rebuilt it.

Maybe, it should be the port's option (or flavor?). Maybe, the port needs to be split into "common" part -- which does not depend on the kernel flags -- and the kernel-modules part, which needs to be built differently for PAE-kernels.

At the very least, a load-time detection of PAE-kernel needs to be implemented so the user gets an actionable hint as to what to do, instead of the incomprehensible "vgdrvFreeBSDAddIRQ failed" followed by "vboxguest0 attach returned 6".

Not even Google knows, what to do about these, although my filing this ticket may help :-) ...
Comment 1 Mikhail Teterin freebsd_committer freebsd_triage 2018-02-16 20:34:03 UTC 
Created attachment 190702 [details]
Add PAE-option

This is worse than I thought, because vboxvfs uses some C++ files, which are compiled without -DPAE.

The attachment helped me, but it is, probably, incomplete in various ways...

And something still needs to be done about virtualbox-ose-kmod too.
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2023-03-13 23:00:26 UTC 
Please, is this still an issue? With virtualbox-ose-6.1.36_1
Comment 3 Graham Perrin 2023-08-19 09:36:50 UTC 
Comment on attachment 190702 [details]
Add PAE-option

Re: comment #2 no feedback, let's assume that this bug report is still valid …
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-06-28 19:26:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c9de267a3525a05df601239c02a960cb98445c76

commit c9de267a3525a05df601239c02a960cb98445c76
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-06-28 19:08:33 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-06-28 19:08:33 +0000

    emulators/virtualbox-ose{,-nox11,-kmod,-additions,-additions-nox11}-legacy: fix build with llvm15+, fix run with PAE on i386

    * Fix build with llvm15+ from ports and from base:
      - ISO C++17 does not allow 'register' storage class specifier;
      - require -fPIC on i386.
    * Fix load kernel modules on host and guest i386 if kernel compiled with
    PAE option: add non-default option PAE to ports.
    Based on patches from mi@.

    PR:             279257 224616
    Approved by:    vbox (maintainer, timeout 1 month and 6 years)

 emulators/virtualbox-ose-additions-legacy/Makefile |  16 +-
 .../virtualbox-ose-additions-nox11-legacy/Makefile |   2 +-
 emulators/virtualbox-ose-kmod-legacy/Makefile      |  15 +-
 emulators/virtualbox-ose-legacy/Makefile           |  28 +-
 .../virtualbox-ose-legacy/files/patch-C++17 (new)  | 301 +++++++++++++++++++++
 .../virtualbox-ose-legacy/files/patch-Config.kmk   |  10 +
 emulators/virtualbox-ose-nox11-legacy/Makefile     |   2 +-
 7 files changed, 354 insertions(+), 20 deletions(-)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-28 19:28:38 UTC 
Thanks.