Bug 224731 - x11/xscreensaver: build fails without XFT
Summary: x11/xscreensaver: build fails without XFT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Niclas Zeising
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-30 15:30 UTC by ml
Modified: 2018-06-19 16:26 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (zeising)

Attachments
possible-patch-xft.c (1.39 KB, text/x-csrc)
2017-12-30 17:52 UTC, Walter Schwarzenfeld 		no flags Details
Fix build without XFT (1.98 KB, patch)
2018-06-17 09:06 UTC, Niclas Zeising 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ml 2017-12-30 15:30:43 UTC 
Disabling XFT, the port fails to build.
Extract of the log:

xft.c:201:39: error: no member named 'rgba_masks' in 'Visual'
      red_shift   = maskbase (visual->rgba_masks[0]);
                              ~~~~~~  ^
xft.c:202:39: error: no member named 'rgba_masks' in 'Visual'
      red_len     = masklen  (visual->rgba_masks[0]);
                              ~~~~~~  ^
xft.c:203:39: error: no member named 'rgba_masks' in 'Visual'
      green_shift = maskbase (visual->rgba_masks[1]);
                              ~~~~~~  ^
xft.c:204:38: error: no member named 'rgba_masks' in 'Visual'
      green_len   = masklen (visual->rgba_masks[1]);
                             ~~~~~~  ^
xft.c:205:39: error: no member named 'rgba_masks' in 'Visual'
      blue_shift  = maskbase (visual->rgba_masks[2]);
                              ~~~~~~  ^
xft.c:206:38: error: no member named 'rgba_masks' in 'Visual'
      blue_len    = masklen (visual->rgba_masks[2]);
                             ~~~~~~  ^
6 errors generated.
Comment 1 Niclas Zeising freebsd_committer freebsd_triage 2017-12-30 16:08:09 UTC 
Hi!
I am aware of the issue, however, it is far from simple to fix and I haven't had time to fiddle around properly.  For now, please use it with XFT (which is the default configuration).
Comment 2 Walter Schwarzenfeld 2017-12-30 17:52:10 UTC 
Created attachment 189227 [details]
possible-patch-xft.c
Comment 3 Walter Schwarzenfeld 2017-12-30 17:53:47 UTC 
I am far from away from be familiar with things like xft or xscreensaver.
But this works on my system.
Please, tell me if this is reasonable or if it is nonsense and obsolete the patch.
Comment 4 ml 2018-01-01 18:27:30 UTC 
(In reply to Niclas Zeising from comment #1)

I try and build this port with as few dependencies as possible, but compiling with XFT is not such a problem to me (in fact that's what I'm already doing).

I only reported this to let you know and to save others the hassle to find out why they can't compile.

I'd be fine if the option was just ditched and XFT forcibly enabled.

BTW, is there a real advantage of building without XFT?
Comment 5 olexander.v.melnyk 2018-01-02 09:21:18 UTC 
(In reply to w.schwarzenfeld from comment #3)
Thanks for the patch, it works for me too.
Comment 6 lichray 2018-06-17 05:50:46 UTC 
Please commit the patch.
Comment 7 Niclas Zeising freebsd_committer freebsd_triage 2018-06-17 09:06:06 UTC 
Created attachment 194325 [details]
Fix build without XFT

Hi!
Can you try the attached patch instead?
Thanks!
Comment 8 lichray 2018-06-18 05:27:42 UTC 
(In reply to Niclas Zeising from comment #7)
Works for me.
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-06-19 16:24:40 UTC 
A commit references this bug:

Author: zeising
Date: Tue Jun 19 16:24:04 UTC 2018
New revision: 472802
URL: https://svnweb.freebsd.org/changeset/ports/472802

Log:
  Fix build without the XFT option.

  PR:		224731
  Reported by:	ml@netfence.it

Changes:
  head/x11/xscreensaver/Makefile
  head/x11/xscreensaver/files/patch-utils_xft.c