Bug 224822 - net-p2p/xmrig: Add rc.d script and other additions
Summary: net-p2p/xmrig: Add rc.d script and other additions
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-01 17:19 UTC by joshruehlig
Modified: 2018-02-10 12:00 UTC (History)
1 user (show)

See Also:

Attachments
net-p2p/xmrig diff (2.67 KB, patch)
2018-01-01 17:19 UTC, joshruehlig 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description joshruehlig 2018-01-01 17:19:59 UTC 
Created attachment 189318 [details]
net-p2p/xmrig diff

The attached diff does the following...

* Add rc.d startup script 
* Moves config.json to ETCDIR and installs it with @sample
* Add pkg-message
* Remove LICENSE_FILE declaration since FreeBSD already has a copy of this

* These changes depend on adding a user "xmrig" to UIDs with a line like...
- "xmrig:*:155:155::0:0:XMRig:/nonexistent:/usr/sbin/nologin"
Available UID numbers can be found here...
- https://github.com/freebsd/freebsd-ports/blob/master/UIDs
Comment 1 joshruehlig 2018-01-03 08:34:53 UTC 
Actually the line added to UIDs should be like so...
- "xmrig:*:155:65534::0:0:XMRig:/nonexistent:/usr/sbin/nologin"

I use the group number "65534" since it is not necessary to add a group for xmrig
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-02-10 09:36:06 UTC 
A commit references this bug:

Author: ehaupt
Date: Sat Feb 10 09:35:50 UTC 2018
New revision: 461370
URL: https://svnweb.freebsd.org/changeset/ports/461370

Log:
  - Update to 2.4.4

  [1] - Add rc.d startup script
      - Move config.json to ETCDIR and install it with @sample
      - Add pkg-message
      - Add  user "xmrig" to UIDs

  PR:		224822 [1]
  Submitted by:	joshruehlig@gmail.com [1]

Changes:
  head/UIDs
  head/net-p2p/xmrig/Makefile
  head/net-p2p/xmrig/distinfo
  head/net-p2p/xmrig/files/
  head/net-p2p/xmrig/files/pkg-message.in
  head/net-p2p/xmrig/files/xmrig.in
  head/net-p2p/xmrig/pkg-plist
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2018-02-10 09:41:22 UTC 
Thank you for your addition. I've committed your patch with minor modifications. I've moved the USES/USE_ block according to portlint's suggestion. I've also restored the LICENSE_FILE definition. There was once a discussion to always use LICENSE_FILE if a license file is provided regardless whether it's already known to the ports system. Unfortunately I can't point to it's source.

While here I've also updated the port to 2.4.4.
Comment 4 joshruehlig 2018-02-10 12:00:38 UTC 
great, thank you.