Created attachment 189495 [details] gnome-twitch.patch https://github.com/vinszent/gnome-twitch Defaulting to MPV backend only, since I couldn't get GStreamer to actually play anything, and it's a large dependency.
Please, do not use ".if" statements when they are replaceable with option helpers.
(In reply to Yuri Victorovich from comment #1) If that's about USE_GSTREAMER1=yes — I wanted to avoid duplication, but okay I can change that to helpers. BACKENDS — I'm not sure how I would use helpers to concatenate strings into one argument…
Ok, thanks, don't worry about this. I will modify it.
This feature proposed by me can greatly simplify all the "if" statements in this port: https://reviews.freebsd.org/D13078 This feature isn't yet accepted. Will wait for a while.
Created attachment 189569 [details] Updated patch I updated the patch using the unreleased feature from https://reviews.freebsd.org/D13078 In order to apply the patch D13078, you need 1. to install arcanist 2. in /usr/ports, run 'arc patch D13078' I will wait until D13078 is committed. Thank you for your submission! Yuri
I think, this GSTREAMER_CAIRO_USE=gstreamer1=yes should be GSTREAMER_CAIRO_USE= gstreamer1=cairo ? I am not familiar with gstreamer1, but how come plugins are used that aren't listed in Mk/bsd.gstreamer.mk? Ex. opengl, clutter. Shouldn't all plugins be listed in Mk/bsd.gstreamer.mk? Are they missing there, or is this expected?
Created attachment 189570 [details] Updated patch
(In reply to Yuri Victorovich from comment #6) Yeah looks like they're missing there.
I don't quite understand how can "GSTREAMER_OPENGL_USE=gstreamer1=yes" and "GSTREAMER_CLUTTER_USE=gstreamer1=yes" work if they don't convey which gstreamer plugin to use if they don't say the name. Greg, do you know how can this work or what should it be changed to?
(In reply to Yuri Victorovich from comment #9) The clutter one has GSTREAMER_CLUTTER_LIB_DEPENDS above! The opengl plugin is default IIRC
Created attachment 190175 [details] Updated shar Current version 0.5.1 fails to build: https://github.com/rylio/ytdl/issues/32
(In reply to Yuri Victorovich from comment #11) Sorry, this was for a different bug.
Created attachment 190176 [details] Updated shar
So the gstreamer plugin it really wants is: hls!
Created attachment 193061 [details] gnome-twitch.patch - updated to current git master, which includes important commits such as https://github.com/vinszent/gnome-twitch/pull/344 - added dep on gstreamer hls
I don't understand why this is blocked by D13078. Just add this to the port and it could be committed now. The port can be amended later when support for OPTIONS_*_SELECTED lands. .for opt in ${OPTIONS_MULTI_BACKEND} ${opt}_VARS= BUILD_PLAYER_BACKENDS+=${opt} .endfor MESON_ARGS= -Dbuild-player-backends=${BUILD_PLAYER_BACKENDS:tl:S/_/-/:ts,}
A commit references this bug: Author: tobik Date: Sat Jan 26 10:48:49 UTC 2019 New revision: 491259 URL: https://svnweb.freebsd.org/changeset/ports/491259 Log: New port: multimedia/gnome-twitch GTK based player for Twitch.tv online live video streams. WWW: http://gnome-twitch.vinszent.com PR: 224980 Submitted by: greg@unrelenting.technology Reviewed by: yuri (earlier version) Changes: head/multimedia/Makefile head/multimedia/gnome-twitch/ head/multimedia/gnome-twitch/Makefile head/multimedia/gnome-twitch/distinfo head/multimedia/gnome-twitch/pkg-descr head/multimedia/gnome-twitch/pkg-plist