Bug 224983 - editors/neovim: Support the NLS option
Summary: editors/neovim: Support the NLS option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-08 06:05 UTC by Adam Weinberger
Modified: 2018-01-08 15:12 UTC (History)
1 user (show)

See Also:
o.hushchenkov: maintainer-feedback+

Attachments
NLS option (3.67 KB, patch)
2018-01-08 06:05 UTC, Adam Weinberger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2018-01-08 06:05:30 UTC 
Created attachment 189500 [details]
NLS option

Hi Oleh,

In general, it's preferred to have an NLS option, rather than forcing NLS to always be installed. The attached patch adds an NLS option (NLS is always enabled by default).
Comment 1 Oleh Hushchenkov 2018-01-08 11:17:58 UTC 
Hi Adam.

Looks good to me.

Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-01-08 15:11:22 UTC 
A commit references this bug:

Author: adamw
Date: Mon Jan  8 15:10:37 UTC 2018
New revision: 458426
URL: https://svnweb.freebsd.org/changeset/ports/458426

Log:
  Add an NLS knob.

  PR:		224983
  Approved by:	Oleh Hushchenkov

Changes:
  head/editors/neovim/Makefile
  head/editors/neovim/pkg-plist
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2018-01-08 15:12:08 UTC 
Committed. Thank you for reviewing so quickly, Oleh!