Bug 225121 - x11/lemonbar: Update to 1.3
Summary: x11/lemonbar: Update to 1.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://github.com/LemonBoy/bar/relea...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-01-12 22:04 UTC by Dmitri Goutnik
Modified: 2018-01-14 15:24 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (evgeni.dimitrov)

Attachments
lemonbar-1.3.patch (1.50 KB, patch)
2018-01-12 22:04 UTC, Dmitri Goutnik 		no flags Details | Diff
lemonbar-1.3.patch (1.58 KB, patch)
2018-01-14 15:05 UTC, Dmitri Goutnik 		dmgk: maintainer-approval?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2018-01-12 22:04:14 UTC 
Created attachment 189666 [details]
lemonbar-1.3.patch

* Update to 1.3
* While here, switch to USES=localbase
* Fix VERSION [1]

Changes [2]:

  - Correct handling of escaped % characters.
  - The WM_NAME atom is now set for all the windows.
  - Fix an unsafe memory access during the argument parsing.
  - Correct the coordinate calculation for the EWMH STRUT atoms.

QA:
  poudriere testport: OK (11a, 10i)

[1] https://github.com/LemonBoy/bar/pull/210
[2] https://github.com/LemonBoy/bar/releases/tag/v1.3
Comment 1 evgeni.dimitrov 2018-01-14 08:52:10 UTC 
Maintainer here.

This looks good to me, but I remember having a discussion here https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205512 about USES+=localbase vs defining CFLAGS. Maybe things have changed and USES+=localbase is prefered now. I don't know.

You can also take ownership of this port if you want as I seem to have lost interest in maintaining or even using it. :)
Comment 2 Dmitri Goutnik freebsd_committer freebsd_triage 2018-01-14 15:05:20 UTC 
Created attachment 189709 [details]
lemonbar-1.3.patch

Hi Evgeni,

I'll leave final decision to committers but USES=localbase seems cleaner to me.

Also updated the patch to take maintainership, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-01-14 15:21:40 UTC 
A commit references this bug:

Author: tobik
Date: Sun Jan 14 15:21:26 UTC 2018
New revision: 458981
URL: https://svnweb.freebsd.org/changeset/ports/458981

Log:
  x11/lemonbar: Update to 1.3

  - Submitter becomes maintainer

  Changes:	https://github.com/LemonBoy/bar/releases/tag/v1.3
  PR:		225121
  Submitted by:	Dmitri Goutnik <dg@syrec.org>
  Approved by:	evgeni.dimitrov@gmail.com (maintainer)

Changes:
  head/x11/lemonbar/Makefile
  head/x11/lemonbar/distinfo
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-01-14 15:24:10 UTC 
Committed. Thanks!

USES=localbase is fine.