Bug 225299 - graphics/libfpx: error: 'register' storage class specifier is deprecated and incompatible with C++17
Summary: graphics/libfpx: error: 'register' storage class specifier is deprecated and ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-18 13:47 UTC by O. Hartmann
Modified: 2018-08-05 21:45 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (freebsd-2024)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2018-01-18 13:47:43 UTC 
On recent CURRENT (FreeBSD 12.0-CURRENT #14 r328101: Wed Jan 17 23:57:27 CET 2018, WITH_LLD_IS_LD=YES, CLANG 6), updating/installing or packaing via poudriere of port graphics/libfpx fails with the error shown below:


[...]
c++  -O2 -pipe -DHAVE_WCHAR_H -DHAVE_DLFCN_H -DHAVE_SYS_TIME_H -DHAVE_SYS_PARAM_H -DHAVE_SYS_MOUNT_H  -fstack-protector-strong -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wpointer-arith -Wno-uninitialized -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-error=tautological-constant-compare -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member  -Qunused-arguments  -fno-rtti -fno-exceptions -fno-strict-aliasing -DHAVE_WCHAR_H -DHAVE_DLFCN_H -DHAVE_SYS_TIME_H -DHAVE_SYS_PARAM_H -DHAVE_SYS_MOUNT_H -I/wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/oless/h -I/wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/jpeg -I/wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/ole -I/wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/basics -I/wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/ri_image -I/wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/oless -I/wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/fpx -I/wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/. -I/usr/local/include -D_UNIX  -Wno-c++11-extensions  -c /wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/fpx/fpxlib.cpp -o fpxlib.o
--- filter.o ---
In file included from /wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/fpx/filter.cpp:37:
In file included from /wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/ri_image/ph_image.h:25:
In file included from /wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/ri_image/priimage.h:33:
In file included from /wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/ri_image/matrix.h:25:
/wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/basics/npixel.h:107:5: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
    register unsigned32 newColor = *((unsigned32 *)(&pix));
    ^~~~~~~~~
--- coltwist.o ---
/wrkdirs/usr/ports/graphics/libfpx/work/libfpx-1.3.1-4/fpx/coltwist.cpp:287:3: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
  register int c1, c2, c3;
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-01-21 01:09:38 UTC 
A commit references this bug:

Author: mi
Date: Sun Jan 21 01:09:18 UTC 2018
New revision: 459561
URL: https://svnweb.freebsd.org/changeset/ports/459561

Log:
  Upgrade from 1.3.1-4 to 1.3.1-10 (security fixes).

  Resolve errors triggered on -current by the use of C++17

  PR:		225299

Changes:
  head/graphics/libfpx/Makefile
  head/graphics/libfpx/distinfo
  head/graphics/libfpx/files/Makefile.bsd
  head/graphics/libfpx/files/patch-null-casts
Comment 2 Mikhail Teterin freebsd_committer freebsd_triage 2018-08-05 21:45:24 UTC 
Seems to have been fixed by the January commit mentioned in Comment #1