Bug 225432 - mail/up-imapproxy: Add dovecot unconditionally in rcfile
Summary: mail/up-imapproxy: Add dovecot unconditionally in rcfile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Danilo G. Baio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-24 15:21 UTC by topical
Modified: 2018-01-29 10:05 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description topical 2018-01-24 15:21:07 UTC 
Bug 163200 added dependency on dovecot2/dovecot as a build option which is OFF by default.

I don't see the any difference between dovecot and cyrus, which is unconditionally added as a dependency. It just means that I have to build my own imapproxy package to make sure service startup order is correct.

So: could you please remove the "DOVECOT" option from the Makefile and add the dependancy unconditionally instead:

--- imapproxyd.orig     2018-01-24 16:05:44.312040000 +0100
+++ imapproxyd  2018-01-24 16:05:54.271595000 +0100
@@ -3,7 +3,7 @@
 # $FreeBSD: branches/2017Q4/mail/up-imapproxy/files/imapproxyd.in 340872 2014-01-24 00:14:07Z mat $
 #
 # PROVIDE: imapproxyd
-# REQUIRE: DAEMON courier_imap_imapd courier_imap_imapd_ssl cyrus_imapd inetd  %%DOVECOT%%
+# REQUIRE: DAEMON courier_imap_imapd courier_imap_imapd_ssl cyrus_imapd inetd dovecot
 # KEYWORD: shutdown

 #

This would be great.

Thank you
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-01-28 13:09:54 UTC 
A commit references this bug:

Author: dbaio
Date: Sun Jan 28 13:09:08 UTC 2018
New revision: 460171
URL: https://svnweb.freebsd.org/changeset/ports/460171

Log:
  mail/up-imapproxy: Add dovecot unconditionally in rcfile

  This helps users that are using default packages and installing
  dovecot manually in having the startup order correctly.

  While here, switch to options helper and reorder Makefile.

  PR:		225432
  Submitted by:	topical@gmx.net

Changes:
  head/mail/up-imapproxy/Makefile
  head/mail/up-imapproxy/files/imapproxyd.in
Comment 2 Danilo G. Baio freebsd_committer freebsd_triage 2018-01-28 13:11:58 UTC 
Committed the change in rcfile.

There is no harm in letting dovecot option in Makefile (someone might be using it).

Thanks.
Comment 3 topical 2018-01-29 10:05:12 UTC 
Great! Thanks a lot!